[#13535] - Fix for issue #13531
- Fixed in Code Base
- 15 Jan 2017
- Medium
- Build: staging
- # 13535
- Diff
- frankmayer:fix-for-issue-13531
User tests: Successful: Unsuccessful:
Pull Request for Issue #13531 .
Summary of Changes
- [AND] and [OR] operators were not functioning correctly. Fixed.
- some cleanup of whitespaces in XML file and hiding of rulers when the encapsulated fields are not showing.
Testing Instructions
Code review (with w=1 because of the whitespace reformat in the xml file) here
Test fields where showon with [AND] and [OR] are implemented.
for example:
[AND]: Articles->Options->"Articles" tab
Only when both "Show "Read More" and "Show Title with Read More" are set to "Show" the "Read More Limit" field should be shown.
[OR]: Articles->Options->"Editing Layout" tab
Only when both "Frontend Images and Links" and "Administrator Images and Links" are set to "Hide" then the five fields under them should be hidden.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content Libraries |
| Labels |
Added:
?
|
||
conflicts, also it seems you change the config.xml indentation. please revert that extra indentation
@frankmayer please reduce the change in the config.xml only to the needed one as the tabs you added are not needed. as @andrepereiradasilva pointet out. that should also fix the merge conflicts.
@zero-24 & @andrepereiradasilva it was a different than Joomla style, code formatting setting for XML in PHPStorm.
Conflicts and whitespace issues have been resolved. Tests and RTC anyone?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13535.
I have tested this item
Test OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13535.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13535.
| Status | Ready to Commit | ⇒ | Pending |
Conflicts resolved... pls test and RTC
I have tested this item
The [AND] and the [OR] example works.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13535.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-15 11:55:00 |
| Closed_By | ⇒ | wilsonge |
I have tested this item✅ successfully on fe73679
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13535.