[#13526] - Make JPluginHelper::load() resilient to cache error
- Fixed in Code Base
- 30 Jan 2017
- Medium
- Build: staging
- # 13526
- Diff
- mbabker:plugin-helper-cache-fallback
User tests: Successful: Unsuccessful:
Partial Pull Request for Issue #13357
Summary of Changes
Similar to #13524 this tries to make the admin JPluginHelper class resilient to cache related issues.
-
The lambda function is now stored in a variable for use in the error handling cases.
-
Cache exceptions are caught and the lambda function will attempt to be run directly instead.
-
On a database failure, we're out of luck; sorry.
Testing Instructions
If the cache store fails to connect or the cache configuration is bad, the exceptions thrown by the cache API should be caught and JPluginHelper::load() try to manually execute the lambda function to load the data. The method is already not dealing with database errors so no new error handling is added regarding that.
Documentation Changes Required
N/A
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
Would like some tests here. Getting 3.7 in a state where some of the core API is resilient to cache store errors would be a huge improvement for user experience.
I have tested this item
Before patch in backend got cache exception when memcached server turned off. After patch plugin exception was resolved and got the same error reported by @csthomas
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13526.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13526.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-30 12:49:44 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I want to test you PR but other part of joomla failed.
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ') ORparent_id= 0' at line 3in libraries/joomla/access/access.php:427
I have created PR for that at #13528.