[#13493] - Make columns centered, where it makes sense (in one file only for now, to get a discussion going)
- Fixed in Code Base
- 8 Feb 2017
- Medium
- Build: staging
- # 13493
- Diff
- frankmayer:centered-columns-1
User tests: Successful: Unsuccessful:
Summary of Changes
-
Make columns centered, where it makes sense and looks nicer than left-aligned ones. For example version columns, single or maximum two-word columns
-
Also fixed CS on that file
Testing Instructions
- Go to Extensions -> Update. Make sure there is a list of updates to view.
- Leave this tab as it is, for comparison. Open a new tab, apply the patch and revisit the update screen.
- Compare and comment / review.
Code review: Due to CS fixes, the changes in this files are best viewed with a setting to ignore whitespaces and empty lines (Apply w=1 argument to files view if viewing on github).
Documentation Changes Required
Maybe to set some standards for formatting of columns.
Example:
Before:
After:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer |
| Title |
|
||||||
tested successfully, watch out if you miss extension updates in latest staging, then change the version.php in libraries/cms/version/ in line 33 to 3.6 - revert this change after your test again.
@coolcat-creations is another View to test? Didn't get extensions after changing const RELEASE = '3.7'; to const RELEASE = '3.6';.
Did you install some outdated extensions, too? be sure all update Sites are also enabled at /administrator/index.php?option=com_installer&view=updatesites
i'm looking for outdated extensions, thanks @coolcat-creations
patch works as it should
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13493.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC based on two successfull tests. i have just converted the spaces to tabs in the last commit.´Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13493.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-08 14:05:03 |
| Closed_By | ⇒ | rdeutz | |
| Labels | |||
I have tested this item✅ successfully on 4db3d97
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13493.