User tests: Successful: Unsuccessful:
Pull Request for Issue #13487.
Fix showon notice
None.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_config |
This PR fixed the issue. However, I still have question if anyone knows the answer
Do we really need this block of code https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_config/view/component/tmpl/default.php#L60-L64 ?
As I understand showon is used for fields only, so I don't know why we need that block of code to check showon for fieldsets?
IIRC you can showon a fields set based on a option too
I have tested this item
Thanks!
That is not correct.
I tried to add showon="sef_advanced:1" to https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_content/config.xml#L1033 but it doesn't work. Permissions tab is not being shown when I change URL Routing between Modern and Legacy
There is also notice if we add showon to fieldset
So either it is not supported or if it is supported, there would still be notice like in my screenshot
OK. Checked it more and see that showon support fieldset, too. However, there is still bug in your code prevents it to work and causes the notice
You need to change $fieldSet->formControl in this line of code https://github.com/andrepereiradasilva/joomla-cms/blob/d6219ac06c7c6fdf94d8c12bcaff38d6645cb88e/administrator/components/com_config/view/component/tmpl/default.php#L63 to $this->form->getFormControl() and everything will work as expected
I have tested this item
I have to update my test result. It is still not working as expected, see my comment above
Thanks Thomas. I tested and saw it.
@joomdonation i will check this better when i have some time later. thanks for your tests
Labels |
Added:
?
|
@joomdonation can you test now?
I have tested this item
I have tested this item
Works OK now, both for fields and fieldsets
Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-07 07:36:19 |
Closed_By | ⇒ | zero-24 | |
Labels |
Added:
?
|
Merged thanks!
I have tested this item✅ successfully on d6219ac
Test success.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13490.