? ? Pending

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
6 Jan 2017

Pull Request for Issue #13487.

Summary of Changes

Fix showon notice

Testing Instructions

  1. Apply patch
  2. go to Content > Articles > Options and no notice error.

Documentation Changes Required

None.

avatar andrepereiradasilva andrepereiradasilva - open - 6 Jan 2017
avatar andrepereiradasilva andrepereiradasilva - change - 6 Jan 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Jan 2017
Category Administration com_config
avatar joomdonation
joomdonation - comment - 6 Jan 2017

I have tested this item successfully on d6219ac

Test success.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13490.

avatar joomdonation joomdonation - test_item - 6 Jan 2017 - Tested successfully
avatar joomdonation
joomdonation - comment - 6 Jan 2017

This PR fixed the issue. However, I still have question if anyone knows the answer

Do we really need this block of code https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_config/view/component/tmpl/default.php#L60-L64 ?

As I understand showon is used for fields only, so I don't know why we need that block of code to check showon for fieldsets?

avatar andrepereiradasilva
andrepereiradasilva - comment - 6 Jan 2017

IIRC you can showon a fields set based on a option too

avatar waader
waader - comment - 6 Jan 2017

I have tested this item successfully on d6219ac

Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13490.

avatar waader waader - test_item - 6 Jan 2017 - Tested successfully
avatar joomdonation
joomdonation - comment - 6 Jan 2017

That is not correct.

  1. I tried to add showon="sef_advanced:1" to https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_content/config.xml#L1033 but it doesn't work. Permissions tab is not being shown when I change URL Routing between Modern and Legacy

  2. There is also notice if we add showon to fieldset

See this screenshot
warning

So either it is not supported or if it is supported, there would still be notice like in my screenshot

avatar joomdonation
joomdonation - comment - 6 Jan 2017

OK. Checked it more and see that showon support fieldset, too. However, there is still bug in your code prevents it to work and causes the notice

You need to change $fieldSet->formControl in this line of code https://github.com/andrepereiradasilva/joomla-cms/blob/d6219ac06c7c6fdf94d8c12bcaff38d6645cb88e/administrator/components/com_config/view/component/tmpl/default.php#L63 to $this->form->getFormControl() and everything will work as expected

avatar joomdonation
joomdonation - comment - 6 Jan 2017

I have tested this item ? unsuccessfully on d6219ac

I have to update my test result. It is still not working as expected, see my comment above


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13490.

avatar joomdonation joomdonation - test_item - 6 Jan 2017 - Tested unsuccessfully
avatar Bakual
Bakual - comment - 6 Jan 2017

As I understand showon is used for fields only, so I don't know why we need that block of code to check showon for fieldsets?

showon is available for fieldsets since 3.6.0 (#9668)

avatar joomdonation
joomdonation - comment - 6 Jan 2017

Thanks Thomas. I tested and saw it.

avatar andrepereiradasilva
andrepereiradasilva - comment - 6 Jan 2017

@joomdonation i will check this better when i have some time later. thanks for your tests

avatar andrepereiradasilva andrepereiradasilva - change - 6 Jan 2017
Labels Added: ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 6 Jan 2017

@joomdonation can you test now?

avatar 810
810 - comment - 6 Jan 2017

I have tested this item successfully on 46fc70d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13490.

avatar 810 810 - test_item - 6 Jan 2017 - Tested successfully
avatar joomdonation
joomdonation - comment - 7 Jan 2017

I have tested this item successfully on 46fc70d

Works OK now, both for fields and fieldsets


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13490.

avatar joomdonation joomdonation - test_item - 7 Jan 2017 - Tested successfully
avatar infograf768 infograf768 - change - 7 Jan 2017
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 7 Jan 2017

RTC. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13490.

avatar zero-24 zero-24 - change - 7 Jan 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-01-07 07:36:19
Closed_By zero-24
Labels Added: ?
avatar zero-24 zero-24 - close - 7 Jan 2017
avatar zero-24 zero-24 - merge - 7 Jan 2017
avatar zero-24
zero-24 - comment - 7 Jan 2017

Merged thanks!

Add a Comment

Login with GitHub to post a comment