? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
6 Jan 2017

Pull Request for Issue # .

Summary of Changes

This PR makes some small clean up to JModelForm clas:

  1. Replace deprecated JArrayHelper::getValue call by ArrayHelper::getValue

  2. Allow using column alias for checked_out and checked_out_time fields like how we handle it in JTable

Testing Instructions

  1. Code review
  2. Try to add/edit a Joomla article, make sure it still works as before

Documentation Changes Required

None

avatar joomdonation joomdonation - open - 6 Jan 2017
avatar joomdonation joomdonation - change - 6 Jan 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Jan 2017
Category Libraries
avatar shivamdiehard
shivamdiehard - comment - 6 Jan 2017

I have tested this item successfully on 1acd6b7

Created and edited the article after applying the patch .
Work as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13485.

avatar shivamdiehard shivamdiehard - test_item - 6 Jan 2017 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 11 Jan 2017

I have tested this item successfully on 1acd6b7

Test OK


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13485.

avatar anibalsanchez anibalsanchez - test_item - 11 Jan 2017 - Tested successfully
avatar jeckodevelopment jeckodevelopment - change - 11 Jan 2017
Milestone Added:
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 11 Jan 2017

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13485.

avatar wilsonge wilsonge - change - 12 Jan 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-01-12 11:18:05
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 12 Jan 2017
avatar wilsonge wilsonge - merge - 12 Jan 2017
avatar wilsonge
wilsonge - comment - 12 Jan 2017

Nice work!

avatar joomdonation
joomdonation - comment - 12 Jan 2017

Thanks for testing and merging :)

Add a Comment

Login with GitHub to post a comment