Feeling Lucky
?
[#13473] - fixed 12953 - Removed methods from JLanguage to JLanguageHelper
- Closed
- 5 Jan 2017
- Medium
- Build: staging
- # 13473
- Diff
- yasirunilan:fix-13464
User tests: Successful: Unsuccessful:
Pull Request for Issue # 12953.
Summary of Changes
Moved methods from JLanguage to JLanguageHelper
Testing Instructions
Code Review
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
RonakParmar
- comment
- 5 Jan 2017
I have tested this item
Done code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13473.
andrepereiradasilva
- comment
- 5 Jan 2017
I have tested this item
This PR is not correct from code review
JLanguageHelper constructor does not generate a JLanguage object.
The remove of deprecated code as already been merged in #13464
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13473.
| Labels |
Added:
?
|
||
zero-24
- comment
- 5 Jan 2017
I'm closing here do of the reasons @andrepereiradasilva posted above. This change is not correct at this state and the other part is fixed by the other PR allready. Thanks!
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-05 17:59:43 |
| Closed_By | ⇒ | zero-24 |
The deprecated method is already replaced in this PR #13464
The other are not correct. Also don't exactly know what is your intend here... what exactly is it fixing from #12953 (which is a PR, not an issue)?