Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#13469] - Fixed broken view in administrator/components/com_languages/views/installed/tmpl/default.php under smaller resolutions

? ? Pending

User tests: Successful: Unsuccessful:

avatar frankmayer
frankmayer
4 Jan 2017

New issue:
Broken view in administrator/components/com_languages/views/installed/tmpl/default.php under smaller resolutions. The Native Title header ins't removed in smaller resolutions due to missing classes

Summary of Changes

Details:

  • Fixed Native Title header
  • Also centered the Language Tag column

Testing Instructions

  1. Test admin interface installed languages without applying patch. Try different resolutions and notice that in smaller (tablet & phone) resolutions, headers and data columns are misaligned.
  2. Apply patch and test again. Headers and columns should now be aligned

Documentation Changes Required

None

avatar frankmayer frankmayer - open - 4 Jan 2017
avatar frankmayer frankmayer - change - 4 Jan 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jan 2017
Category ⇒ Administration com_languages
avatar frankmayer frankmayer - change - 4 Jan 2017
Labels Added: ?
avatar infograf768
infograf768 - comment - 4 Jan 2017

Hmm. Native Title is not even shown on some Tablet sizes (800x600 and 768x1024)
I suggest to modify to get it there:
screen shot 2017-01-04 at 08 40 51

To get this, we should imho take off the nowrap and hidden-tablet, i.e. I propose this diff:

diff --git a/administrator/components/com_languages/views/installed/tmpl/default.php b/administrator/components/com_languages/views/installed/tmpl/default.php
index c83d49a..9102a1d 100644
--- a/administrator/components/com_languages/views/installed/tmpl/default.php
+++ b/administrator/components/com_languages/views/installed/tmpl/default.php
@@ -40,8 +40,8 @@
 						<?php echo JHtml::_('searchtools.sort', 'JGLOBAL_TITLE', 'name', $listDirn, $listOrder); ?>
 					</th>
-					<th width="15%" class="nowrap">
+					<th width="15%" class="hidden-phone">
 						<?php echo JHtml::_('searchtools.sort', 'COM_LANGUAGES_HEADING_TITLE_NATIVE', 'nativeName', $listDirn, $listOrder); ?>
 					</th>
-					<th class="nowrap">
+					<th class="nowrap center">
 						<?php echo JHtml::_('searchtools.sort', 'COM_LANGUAGES_HEADING_LANG_TAG', 'language', $listDirn, $listOrder); ?>
 					</th>
@@ -91,8 +91,8 @@
 						</label>
 					</td>
-					<td class="hidden-phone hidden-tablet">
+					<td class="hidden-phone">
 						<?php echo $this->escape($row->nativeName); ?>
 					</td>
-					<td>
+					<td class="center">
 						<?php echo $this->escape($row->language); ?>
 					</td>
avatar frankmayer
frankmayer - comment - 4 Jan 2017

I don't know, but to me this seems a waste of space. The field seems rarely used and holds redundant information. Pls look at the example below, where there are also a lot of other languages installed:
screenshot-joomla-patch-tester-1 2017-01-04 10-24-42

avatar frankmayer
frankmayer - comment - 4 Jan 2017

Another approach could be to show this info as a ToolTip when user hovers over the Title column or the entire row.

avatar infograf768
infograf768 - comment - 4 Jan 2017

The field is rarely used for now because it is a new feature in the xml metadata, Language packs will be updated for 3.7 and will populate the column.
Example for the future French 3.7.0.1 pack

<metadata>
		<name>French (FR)</name>
		<nativeName>Français (France)</nativeName>
		<tag>fr-FR</tag>
		<rtl>0</rtl>
		<locale>fr_FR.utf8, fr_FR.UTF-8, fr_FR.UTF-8@euro, fr_FR, fre_FR, fr, france</locale>
		<firstDay>1</firstDay>
		<weekEnd>0,6</weekEnd>
		<calendar>gregorian</calendar>
	</metadata>
avatar anibalsanchez
anibalsanchez - comment - 5 Jan 2017

I have tested this item ✅ successfully on 932441c

Test OK

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13469.

avatar anibalsanchez anibalsanchez - test_item - 5 Jan 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 6 Jan 2017

I have tested this item ✅ successfully on 932441c

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13469.

avatar infograf768 infograf768 - test_item - 6 Jan 2017 - Tested successfully
avatar infograf768 infograf768 - change - 6 Jan 2017
Status Pending ⇒ Ready to Commit
avatar infograf768
infograf768 - comment - 6 Jan 2017

RTC. Thanks

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13469.

avatar Bakual Bakual - change - 6 Jan 2017
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-01-06 07:10:17
Closed_By ⇒ Bakual
Labels Added: ?
avatar Bakual Bakual - close - 6 Jan 2017
avatar Bakual Bakual - merge - 6 Jan 2017

Add a Comment

Login with GitHub to post a comment