[#13462] - [com_fields] Custom Fields Media Field if class is empty still class is shown as attribute
- Fixed in Code Base
- 27 Jan 2017
- Medium
- Build: staging
- # 13462
- Diff
- zero-24:fields_class
User tests: Successful: Unsuccessful:
Pull Request for Issue #13400
Summary of Changes
Don't let the class tag alone without content
Testing Instructions
Create an media field and don´t fill the image class field.
There is an empty class attribute shown in the Source code
Apply the patch and make sure there is no class tag anymore but if you set a class it comes back
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_fields |
| Labels |
Added:
?
|
||
| Category | Front End com_fields | ⇒ | Front End Plugins |
@coolcat-creations @laoneo i have updated the PR after the changes in #13319 please review and test here.
Please use $fieldParams->get('image_class') to get the image class. The inheritance from the plugin works.
Just saw that getting the directory is also wrong, can you change it to $fieldParams->get('directory', '/') as well?
fixed.
I have tested this item
Before Patch:
<dd class="field-entry " id="field-entry-8">
<span class="field-label">Media: </span>
<span class="field-value"><img src="/Joomla/images/joomla_black.png" class=""/></span>
</dd>
After Patch:
<dd class="field-entry " id="field-entry-8">
<span class="field-label">Media: </span>
<span class="field-value"><img src="/Joomla/images/joomla_black.png""/></span>
</dd>
</dl>
There ist a " to much at joomla_black.png""
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13462.
@laoneo @franz-wohlkoenig the last commits should do it thanks!.
I have tested this item
After PR empty Class is gone.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13462.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13462.
@franz-wohlkoenig please test it with a class and without. For me it worked.
@franz-wohlkoenig can you retest this one, that we can get it in?
I have tested this item
With and without a class (i.e. span4 offset1) class isn't shown in source code.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13462.
Ready for commit then, thanks.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13462.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-27 18:22:10 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Can we put this one on hold till #13319 is merged. Then this one needs to be redone in the plugin itself. Thanks.