? ? Pending

User tests: Successful: Unsuccessful:

avatar frankmayer
frankmayer
1 Jan 2017

Summary of Changes

[administrator/components] Fix alignment for arrays and for some assignments. + insert one blank line.

Testing Instructions

None, code review only.

Documentation Changes Required

None.

avatar frankmayer frankmayer - open - 1 Jan 2017
avatar frankmayer frankmayer - change - 1 Jan 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jan 2017
Category Administration com_banners com_categories com_contact com_content com_finder com_languages com_login com_media com_menus com_messages com_modules com_newsfeeds com_plugins com_redirect com_tags com_templates com_users
avatar frankmayer frankmayer - change - 1 Jan 2017
Labels Added: ?
avatar anibalsanchez
anibalsanchez - comment - 5 Jan 2017

I have tested this item successfully on 3a71e07

Code review OK


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13440.

avatar anibalsanchez anibalsanchez - test_item - 5 Jan 2017 - Tested successfully
avatar Quy
Quy - comment - 28 May 2017

I have tested this item successfully on 3a71e07


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13440.

avatar Quy Quy - test_item - 28 May 2017 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 28 May 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 28 May 2017

RTC after two successful tests.

avatar frankmayer
frankmayer - comment - 28 May 2017

@franz-wohlkoenig there is a conflicting file. Should I fix this first?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 28 May 2017

@frankmayer yes, please.

avatar frankmayer frankmayer - change - 28 May 2017
Labels Added: ?
avatar frankmayer
frankmayer - comment - 28 May 2017

@franz-wohlkoenig done (seems the Appveyor queue is stuck, though...)

avatar rdeutz rdeutz - change - 6 Jun 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-06-06 17:49:51
Closed_By rdeutz
avatar rdeutz rdeutz - close - 6 Jun 2017
avatar rdeutz rdeutz - merge - 6 Jun 2017

Add a Comment

Login with GitHub to post a comment