User tests: Successful: Unsuccessful:
Inspired by the changes @andrepereiradasilva did in #13427
JLanguageHelper::parseIniFile($fileName)
method."_qq_"
string translation in site and administrator"_qq_"
string translation in site and administratorNo, if fully automated generation
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_languages Libraries |
Labels |
Added:
?
|
CS issues fixed. Ready for reviews & tests!
@frankmayer can you please look at the conflicting file?
@frankmayer i was actully doing this as part of the _QQ_
deprecation :)
I was already in the testing phase of the PR, but i got sick
Anyway since you already done it, please compare with the PR in my repo https://github.com/andrepereiradasilva/joomla-cms/pull/121/files if you want
@andrepereiradasilva Oops!!! I wasn't aware that you were also doing unification... We had the same thing in mind
So, please do your PR as planned. I'll close mine instead.
And please take anything you might need from this one.
PS. I hope you're better now.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-02 15:52:47 |
Closed_By | ⇒ | frankmayer |
there was no need to close it. but ok i will submit mine when tested
[EDIT] Could we please change the CS rule that expects exactly 2 spaces in Multi-line function declaration? And also maybe to allow spaces to indent in these cases?
It is easier to read the way I did it in this PR. (Not the one with the spaces instead of the tabs of course. Will change that into tabs, too)