[#13420] - [com_fields] Change Jtext String issue #13393
- Fixed in Code Base
- 6 Jan 2017
- Medium
- Build: staging
- # 13420
- Diff
- coolcat-creations:rename_hint_label_and_tooltip
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Change Change text
Pull Request for Issue #13393.
Summary of Changes
Changed Hint to Placeholder and made the description in the tooltip more clear.
before:
after:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields Language & Strings |
JFormField (stupidly) calls a placeholder a "hint" versus the correct term used by, oh, the entire internet. So we're running into a case now where either we use the Joomla term and be wrong everywhere or we use the right term in the UI and hope people are informed enough to realize that the attribute it's actually setting in the code has a different name.
I agree with this. As Allon pointed out, it's used on every field type, not just text fields, so I would amend the text to "A placeholder which will appear inside the field input as a hint"
We can change the text string without changing the XML field name so it doesn't affect anything but the display. Placeholder is much more appropriate text in this case.
I would also consider the possibility of only having placeholder inputs shown on field types that can actually utilize them. If the field type doesn't support a placeholder then it shouldn't be an option. I imagine changing this to be field type specific would take some work but I'm not entirely sure how much work. It's something we should consider either way.
I have tested this item
Works as described in "Summary of Changes"
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13420.
infograf768
- | Title |
|
||||||
I have tested this item
Test OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13420.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13420.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-06 18:31:09 |
| Closed_By | ⇒ | rdeutz |
The hint field is available in all form fields, that's why I called it hint and not placeholder https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/form/field.php#L36. It is not specific to input fields, otherwise it would be available only for the text form field. But honestly I don't know if other extension developers are using it as in core it is only used with text input fields.