[#13417] - Use $this->connection = null; rather than unset()
- Closed
- 30 Dec 2016
- Medium
- Build: staging
- # 13417
- Diff
- photodude:patch-4
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue Use $this->connection = null; rather than unset()
Summary of Changes
unset() will undeclare the class member variable, we don't want to do that.
replicates framework changes
Testing Instructions
merge by code review
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
@frankmayer I'm not sure. The only thing I'm aware of is the issue with using unset in this case. (I'm also unaware of anyone actively using the oracle driver; this change is being made as a code consistency item)
All of the database drivers should call the disconnect method. This ensures
whenever a driver class is destroyed, no lingering connections to the
database are left open. If you look, the drivers that are not calling
disconnect basically duplicate the code in that method.
On Thu, Dec 29, 2016 at 5:59 PM Walt Sorensen notifications@github.com
wrote:
@frankmayer https://github.com/frankmayer I'm not sure. The only thing
I'm aware of is the issue with using unset in this case. (I'm also unaware
of anyone actively using the oracle driver; this change is being made as a
code consistency item)—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#13417 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfoRQqdwETQRgP199ZwDG1pbXYvzgYks5rNElngaJpZM4LX6pq
.--
- Michael Please pardon any errors, this message was sent from my iPhone.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-30 15:43:07 |
| Closed_By | ⇒ | photodude |
@photodude just looking into this. Only one question. I cross-checked with the other drivers (mysqli, postgres, sqlsrv) and of those all call a disconnect() function which does some more work than only setting that to null. Is this not needed for the oracle driver?