[#13414] - Some improvements in tests #6:
- Fixed in Code Base
- 10 Jun 2017
- Medium
- Build: staging
- # 13414
- Diff
- frankmayer:improvements-in-tests-6
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
- merged unset() calls
- declared a few properties
Testing Instructions
Code review only.
A lot of unset() merging. Except for 6-7 property declarations. Should be easy to review, though.
PRIORITY: LOWEST
Unified view for reviewing is recommended.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests |
@laoneo (You're killing me...
But it would also be nice if my existing PR's could finally be reviewed/merged. I have put a lot of work into all of this, and also did a lot of work splitting the really big ones up into more logical chunks to help you people review them.
There are a lot of smaller ones or ones with only one specific type of change, which should be relatively easy to review. When those are merged, I can also move on with conflict resolving of the initial big ones, which will result a lot less changes to finally review those ones, too.
Note, that I am aware that, with my PR's I have also put a lot of weight on the shoulders of the reviewers, but these are one time cleanups that would have to be done either way, to improve Joomla. So, please do help me, help you (Joomla Project
It would be nice to limit this PR to unset only. I am unsure of the declaration of properties to give this a successful test.
I have tested this item
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13414.
I have tested this item
on code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13414.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-10 18:47:13 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
@frankmayer I have another request. Can you also please exclude administrator/com_media from your cleanup please. We are redoing the new media manager and are touching almost any file there. So it will help us to stay up to date with staging.