? ? Success

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
29 Dec 2016

This is the third of a set of PR's that's hopefully going to result in us using the code sniffer on the unit tests folder as well (so far ignored because it's a nightmare effort). This fixes issues where we have brackets for classes with no params

avatar wilsonge wilsonge - open - 29 Dec 2016
avatar wilsonge wilsonge - change - 29 Dec 2016
Status New Pending
avatar wilsonge wilsonge - change - 29 Dec 2016
The description was changed
avatar wilsonge wilsonge - edited - 29 Dec 2016
avatar joomla-cms-bot joomla-cms-bot - change - 29 Dec 2016
Category Unit Tests
avatar jeckodevelopment jeckodevelopment - change - 29 Dec 2016
Milestone Added:
avatar photodude
photodude - comment - 30 Dec 2016

Applying the code standards to the unit tests Sounds like a perfect test case for using the PHPCS 2.x auto fixers
joomla/coding-standards#109

avatar wilsonge
wilsonge - comment - 31 Dec 2016

Go for it :)

avatar wilsonge
wilsonge - comment - 31 Dec 2016

I'm closing this PR though in favour of another I'm about to do

avatar wilsonge wilsonge - change - 31 Dec 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-12-31 11:56:06
Closed_By wilsonge
avatar wilsonge wilsonge - close - 31 Dec 2016

Add a Comment

Login with GitHub to post a comment