[#13407] - [JLanguage] Simplify language file parse
- Fixed in Code Base
- 2 Jan 2017
- Medium
- Build: staging
- # 13407
- Diff
- andrepereiradasilva:patch-5
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Improvement.
Summary of Changes
- Remove the
_QQ_str_replace since parse_ini_file already does that as we already have defined constant_QQ_
Constants may also be parsed in the ini file so if you define a constant as an ini value before running parse_ini_file(), it will be integrated into the results. Only ini values are evaluated.
Source: http://php.net/manual/en/function.parse-ini-file.php
- Some other micro optimizations
Testing Instructions
- Apply patch in latest staging
- Make sure all string with
"_QQ_"are still translated to".
Documentation Changes Required
None.
Notes
When i have time i plan to make a PR to remove all _QQ_ from the language files.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
this PR will not remove _QQ_ processing. That would not be B/C.
Is just removing a double processing of _QQ_
The other one that i plan to make will remove _QQ_ from joomla core ini files, but not remove the core compability with _QQ_ processing (should always be processed trough this parse as long as the _QQ_ is defined as a constant in the beggining of this file).
I have tested this item "_QQ_" is still being translated as expected.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13407.
I have tested this item _QQ_ translates to " as expected.
Tested on Back-End and Front-End.
Nice one!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13407.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13407.
| Status | Pending | ⇒ | Ready to Commit |
| Title |
|
||||||
RTC. Thanks.
Concerning changing ALL "_QQ_" in core files, it is a different matter as I explained to you in private.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13407.
No need to test again. Can be merged.
jeckodevelopment
- | Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-02 01:00:21 |
| Closed_By | ⇒ | rdeutz |
if I remember well, we had good reasons to keep the
_QQ_.Also, it is used 1865 times in ini files...