? ? Success

User tests: Successful: Unsuccessful:

avatar alikon
alikon
29 Dec 2016

Pull Request for Issue #13386 .

Summary of Changes

  • added link to users item to com_users
  • added link to articles item to com_content
  • added link to OS item to com_admin&view=sysinfo#site
  • added link to PHP item to com_admin&view=sysinfo#phpinfo
  • added link to DB item to com_config#page-server
  • added link to Time item to com_config#page-server
  • added link to Caching item to com_config#page-system
  • added link to Gzip item to com_config#page-system

Testing Instructions

  1. code review
  2. apply the patch
  3. Extensions -> Modules -> Statistics
  4. Enable Site Information
  5. the Users & Articles items are now linked to their components

linkable

Additional Info

integrated with weblinks see #13389 and joomla-extensions/weblinks#288

avatar alikon alikon - open - 29 Dec 2016
avatar alikon alikon - change - 29 Dec 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Dec 2016
Category Modules Administration
avatar alikon alikon - change - 29 Dec 2016
The description was changed
avatar alikon alikon - edited - 29 Dec 2016
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 29 Dec 2016

I have tested this item successfully on 0d80313

Works as expected; thanks for Enhancement.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13396.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 29 Dec 2016 - Tested successfully
avatar ralain
ralain - comment - 29 Dec 2016

I have tested this item successfully on 0d80313


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13396.

avatar ralain ralain - test_item - 29 Dec 2016 - Tested successfully
avatar jeckodevelopment jeckodevelopment - change - 29 Dec 2016
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 29 Dec 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13396.

avatar jeckodevelopment jeckodevelopment - change - 29 Dec 2016
Milestone Added:
avatar zero-24
zero-24 - comment - 29 Dec 2016

Hmm i don't want to sound bad but what is the reason for that link?

For me the admin UI is now even more complicated as we have 9 entrys (+ weblinks) but just 2/3 with a link? And i don't see the reason for just the third place we link to com_content

avatar chrisdavenport
chrisdavenport - comment - 29 Dec 2016

@alikon I'm just wondering if it might be better to style the count in the same way we do on, for example, the category screens. Then have the count be a clickable link, rather than the text. That might be a little more consistent with those other screens. What do you think?

avatar alikon alikon - change - 30 Dec 2016
Labels Added: ?
avatar alikon
alikon - comment - 30 Dec 2016

@zero-24 one click less from control panel to Users & Articles
for the others module items i was thinking to make those linkable as well, for example :

  • Caching -> link to com_config and open the system tab
  • databaase -> link to com_config and open the server tab
  • etc
    but i'm unable to do the js code to link the specific tab any help on this ?

@chrisdavenport done
chris

avatar alikon alikon - change - 30 Dec 2016
Labels Added: ?
avatar rdeutz rdeutz - change - 30 Dec 2016
Status Ready to Commit Needs Review
Labels
avatar rdeutz
rdeutz - comment - 30 Dec 2016

I am setting this to needs review, would be good to hear something from the ui/ux team on this @cpfeifer


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13396.

avatar joomla-cms-bot joomla-cms-bot - change - 30 Dec 2016
Milestone Removed:
avatar dgt41
dgt41 - comment - 30 Dec 2016

but i'm unable to do the js code to link the specific tab any help on this ?

I can help here, let me prepare something

avatar alikon
alikon - comment - 30 Dec 2016

thanks @dgt41, i was hoping for some help by js expert like you

avatar dgt41
dgt41 - comment - 30 Dec 2016
avatar ghazal
ghazal - comment - 30 Dec 2016

I have tested this item successfully on 9c53d4b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13396.

avatar ghazal ghazal - test_item - 30 Dec 2016 - Tested successfully
avatar cpfeifer
cpfeifer - comment - 30 Dec 2016

@rdeutz I think this is a great improvement. Anything we can do to add useful interactions to the dashboard is welcomed in my opinion.

avatar mbabker
mbabker - comment - 30 Dec 2016

Personal opinion, I think this is just adding links for the sake of adding links. It's a statistics module intended to give a rollup of various data points (and finally pluggable in 3.7), I don't see it as an element that should be providing site navigation.

The linked counts in the category views have a useful purpose, they provide quick filters to a given category and publication state in the component's item list view. What purpose do these links serve?

avatar zero-24
zero-24 - comment - 30 Dec 2016

About short links we already have them with one click on the left sidebar for users and articles ;)

Is it not more confusing to have 100 options on one screen that do the same?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 Dec 2016

@zero-24 You're right about confusing, but there's one Link for user as Example, other Link is behind a Menu. Its about User, to choose which way benefit her. Personally i like Shortcuts, another way to improve Joomla!.

avatar cpfeifer
cpfeifer - comment - 30 Dec 2016

I like it because it provides a fast and easy way for users to see where the stats are coming from. If it says "20 users" for example, and that doesn't seem right to the admin they can go directly to the user manager and see what is happening.

Plus, some of the dashboard stat module concepts I'm currently working on include these links so I think this is a good step towards the future. I'm still working that out, and this change may not have a huge impact in 3.7, but there will be more of this kind of thing coming.

avatar cpfeifer
cpfeifer - comment - 30 Dec 2016

I have tested this item successfully on 9c53d4b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13396.

avatar cpfeifer cpfeifer - test_item - 30 Dec 2016 - Tested successfully
avatar dgt41
dgt41 - comment - 30 Dec 2016

@alikon can you merge my PR?

avatar mbabker
mbabker - comment - 30 Dec 2016

Maybe with those new concepts it might make sense, but in the current module's build, this honestly seriously feels like it's shoving more links in place for the sake of shoving more links in. Especially with the discussion about linking the server metric items to a specific tab on a specific page. I do not see how this feature is more beneficial than not.

Yes, I get it might be a convenient shortcut, but when you stop focusing on this module without any additional context and look at its general use, it is displayed on a page where all of these resources are at most a couple of clicks away. It feels like overkill to me; do we really need 3 or possibly more links to the Article Manager on the admin control panel?

avatar alikon
alikon - comment - 30 Dec 2016
avatar cpfeifer
cpfeifer - comment - 30 Dec 2016

The link is in the number and the change is very small. Design-wise it's basically adding a color highlight to page element which already exists while providing a shortcut. I don't see any downsides to this change.

avatar mbabker
mbabker - comment - 30 Dec 2016

That PR to add the JavaScript to link to specific tabs honestly makes me like this less. But hey, if everyone's OK with a UI where almost every element is navigable in some form and causes actions to be duplicated on the same screen then who am I to stop it?

Linking the items is one thing. Hiding the link in a badge that doesn't even look like a clickable element just makes it worse.

avatar mbabker
mbabker - comment - 30 Dec 2016

And just for all fairness, I think it's equally bad with WordPress' default dashboard.

screen shot 2016-12-30 at 12 31 54 pm

The shortcuts there are to items that are 250 pixels to the left (from the far right edge of posts to the far left edge of the icons) and 330 pixels above (from bottom edge of posts to the top of its icon). Seriously it just feels like link shoving to me. It'd be another argument altogether if it were the only navigation element to that section on the page or added some value (a filter or a quick add/edit action), but it's not either here nor with WordPress. And here we're adding JavaScript to make a link take someone to a specific tab on a specific page; are we going to add anchors to pages to drop someone on a specific line or add more JavaScript to highlight the specific section of the page too?

avatar alikon
alikon - comment - 1 Jan 2017

thanks to @dgt41 now all items are linkable and open the correct tab
linkable

avatar alikon alikon - edited - 1 Jan 2017
avatar alikon alikon - change - 1 Jan 2017
The description was changed
avatar alikon alikon - edited - 1 Jan 2017
avatar frankmayer
frankmayer - comment - 3 Jan 2017

A lot of times I miss "interconnection" and easier moving around between things in Joomla. I think this PR is a good step forward into that direction.

However, I think @mbabker is right, in that it's not that clear to the user, that the link is "hidden" in a badge.

How about using buttons instead of labels? Like this (like the other buttons that also make it clear for the user that it is a something clickable).

nimbus-image-1483474033126

This is only using btn btn-info instead of badge badge-info.

Or maybe just put links on the labels, for example OS, PHP etc... like in the "RECENTLY ADDED ARTICLES" above.

avatar mbabker
mbabker - comment - 3 Jan 2017

That's even worse stylistically. Honestly, I think I could live with it if just the users and articles items were linked, but I seriously think all this extra linking for the server metrics is taking it too far. What is really being gained by direct linking the time stamp to the server tab on the global config here, especially as the global timezone is the configuration item and the time is NOT a manageable item in a website (unless you know of a PHP app that lets you change the physical server's time)? This is where it feels like we're link stuffing for the sake of linking all the things and why in general I'm adamantly against this PR. Someone took an idea and went too far with it.

avatar alikon
alikon - comment - 3 Jan 2017

i like the btn btn-info
let's see what the maintainers decide

avatar jeckodevelopment
jeckodevelopment - comment - 3 Jan 2017

Well, personal opinion on that:

  • In favour of linking "Articles", "Users", "Weblinks".
  • Against all the linked configuration values.

Have all these links to me is almost meaningless.

avatar frankmayer
frankmayer - comment - 3 Jan 2017

@mbabker stylistically, I like the btn version better than the badge, though I admit, the btn ought to be a bit narrower to not be that bulky, which I guess is the stylistic concern you have. But keep in mind it was only a quick demo to show an example, here.

avatar mbabker
mbabker - comment - 3 Jan 2017

Honestly I think the badges work fine but they really aren't intended to be used as navigable elements (same issue exists elsewhere in the backend where badges are linked). Using buttons would definitely fix that, but I'm going to assume (because I don't know what exists in Joomla Bootstrap anymore) there's going to be yet another button variant added to the CSS for this just to deal with the margin/padding.

avatar brianteeman
brianteeman - comment - 16 Aug 2017

@mbabker as release lead for 3.8 can we have a decision on this please so that it is either accepted or rejected. No point in asking for merge conflicts to be resolved if it is either going to sit here forever or rejected

avatar mbabker
mbabker - comment - 16 Aug 2017

Link support in general, I can live with. Linking to managers for those items, feels like link stuffing but if it helps users then OK I guess. Linking every item to either a specific tab or field, that's the part I don't like at all. Keep scope to linking articles and users and I'm OK with this.

avatar brianteeman
brianteeman - comment - 9 Sep 2017

@alikon
Can you look at resolving the conflicts so that this can be tested please and the comment from @mbabker

avatar alikon
alikon - comment - 9 Sep 2017

conflict resolved
link only on articles and users

avatar alikon alikon - change - 9 Sep 2017
The description was changed
avatar alikon alikon - edited - 9 Sep 2017
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 9 Sep 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 9 Sep 2017

I have tested this item successfully on b2537d3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13396.

avatar Quy
Quy - comment - 22 Sep 2017

This module is no longer installed in v3.8. Do you know why?

With the styling, these links are very prominent. I prefer them to be subtle like links in Recently Added Articles.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Oct 2017

@alikon any Update on this PR?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13396.

avatar alikon
alikon - comment - 26 Oct 2017

What update @franz-wohlkoenig ?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Oct 2017

Comment by @Quy above:

This module is no longer installed in v3.8. Do you know why?

With the styling, these links are very prominent. I prefer them to be subtle like links in Recently Added Articles.

avatar Sieger66 Sieger66 - test_item - 6 Jan 2018 - Tested successfully
avatar Sieger66
Sieger66 - comment - 6 Jan 2018

I have tested this item successfully on b2537d3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13396.

avatar franz-wohlkoenig franz-wohlkoenig - change - 7 Jan 2018
Status Needs Review Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Jan 2018

Ready to Commit after two successful tests.

avatar mbabker mbabker - change - 12 May 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-05-12 18:37:55
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 12 May 2018
avatar mbabker mbabker - merge - 12 May 2018

Add a Comment

Login with GitHub to post a comment