Feeling Lucky
?
[#13390] - 2 to 1 loop optimization in plugins/search/categories/categories.php
- Fixed in Code Base
- 29 Dec 2016
- Medium
- Build: staging
- # 13390
- Diff
- frankmayer:foreach_in_plugins
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
This PR optimizes two independent loops of the same (one for and one foreach) into a single loop.
Additionally, the costly assignments are now only executed, when it makes sense (aka the condition is true).
This PR is an optimized extension of the rejected PR #12299
Testing Instructions
Should not change behavior.
Code review
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
laoneo
- comment
- 29 Dec 2016
@frankmayer can you please exclude com_fields and the system plugin from your code style cleanup. I do a bigger refactoring and don't want to solve conflicts regularly. Thanks for understanding.
dgt41
- comment
- 29 Dec 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13390.
| Status | Pending | ⇒ | Ready to Commit |
jeckodevelopment
- | Milestone |
Added: |
||
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-29 15:07:09 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 83c6435
Code review.
Also aplied patch, enabled search component and search plugins, created categories and frontend search found the categories.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13390.