Feeling Lucky
?
[#13385] - Some more improvements in /layouts
- Fixed in Code Base
- 11 Jun 2017
- Medium
- Build: staging
- # 13385
- Diff
- frankmayer:some-more-changes-in-layouts
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
- some type-safe comparisons
- some removal of redundant code -
- fix of misspelled (case) method call
- replacing of deprecated method call
Testing Instructions
Should not change behavior.
- Code review
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
frankmayer
- comment
- 9 Feb 2017
Conflict resolved. Pls test and RTC,
Quy
- comment
- 28 May 2017
Replace of deprecated method call?
https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/modal/main.php#L153
Quy
- comment
- 28 May 2017
I have tested this item
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13385.
frankmayer
- comment
- 28 May 2017
Thanks, one more tester to get this RTC?
andrepereiradasilva
- comment
- 31 May 2017
I have tested this item
on code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13385.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 31 May 2017
RTC after two successful tests.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-11 11:36:46 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on c6d5988
Code Review OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13385.