[#13376] - Execute sql uninstall query (if exists) on extension install abort
- Fixed in Code Base
- 29 Dec 2016
- Medium
- Build: staging
- # 13376
- Diff
- andrepereiradasilva:patch-19
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for New Issue.
Summary of Changes
Currently when a extension install is aborted and the install sql query already run we get a broken install.
The extension is uninstalled but the database tables will stay in joomla.
This PR proposes to change that by adding a step to rollback the sql (if an uninstall sql exists).
Testing Instructions
- Code review
- Install this broken com_test.zip extension that install with a db table called
#__test. Notice you get the extension install rollback but you stay with the#__testtable in the database - Manually delete the
#__testtable - Apply patch
- Repeat step 2 and notice now on failure the
#__testtable is also removed.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
| Category | Libraries | ⇒ | Libraries Unit Tests |
| Labels |
Added:
?
|
||
that's why i putted the if ($route === 'install'
https://github.com/joomla/joomla-cms/pull/13376/files#diff-b88334a2e44587a12ed5fed7beb8bd1eR478
But please test that scenario also
I have tested this item
Done code review.
Note: I also tested installing the extension completely (by removing the exception) and then re-installing the broken one (with the addition of an exception in the update method). The existing table stayed intact, as expected.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13376.
That's why i putted the if ($route === 'install'
https://github.com/joomla/joomla-cms/pull/13376/files#diff-b88334a2e44587a12ed5fed7beb8bd1eR478
But please test that scenario also
Exactly my fear it would be destructive, i will test too
I mean i ll test to "update" an already installed extension with a broken package
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13376.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13376.
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-29 10:38:17 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I haven't tested this yet, but one question comes to mind:
What happens if an extension is installed on top of the same? I am thinking of updating an extension by installing it on top of itself.
If that "update" fails, wouldn't it destroy for example the data of the previously working extension?