? ? Success

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
25 Dec 2016

Summary of Changes

This pull add the description to the Source and Target panel in TinyMCE builder.
Should help to make a bit more clear, how the builder works:


screen 2016-12-25 15 22 25 661x331

If there an idea with better text for explanation, please comment, I will change.

Testing Instructions

Review my English ?

Documentation Changes Required

nope

avatar Fedik Fedik - open - 25 Dec 2016
avatar Fedik Fedik - change - 25 Dec 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Dec 2016
Category Administration Language & Strings Layout
avatar Fedik Fedik - change - 25 Dec 2016
Labels Added: ? ?
avatar Fedik Fedik - change - 25 Dec 2016
Title
Add some description TinyMCE builder, to make it more clear.
Add some description to TinyMCE builder, to make it more clear.
avatar Fedik Fedik - edited - 25 Dec 2016
avatar Fedik Fedik - change - 25 Dec 2016
Title
Add some description TinyMCE builder, to make it more clear.
Add some description to TinyMCE builder, to make it more clear.
avatar infograf768
infograf768 - comment - 25 Dec 2016

I guess we have to normalise drag and drop
We have already 2 ways
PLG_TINY_FIELD_DRAG_DROP_DESC="Enable drag and drop for uploading images"
PLG_TINY_FIELD_DRAG_DROP_LABEL="Images Drag & Drop"

You add a new way:
(drag&drop)

Looks like we could use drag and drop
Oxford Dictionnary:
https://en.oxforddictionaries.com/definition/drag_and_drop

avatar infograf768
infograf768 - comment - 26 Dec 2016

@Fedik
Can you correct the new lang string and modify to fit the 2 others in this PR?

avatar Fedik
Fedik - comment - 26 Dec 2016

@infograf768 done ?

avatar infograf768
infograf768 - comment - 26 Dec 2016

The label should have caps, i.e.
PLG_TINY_FIELD_DRAG_DROP_LABEL="Images Drag and Drop"

avatar infograf768
infograf768 - comment - 26 Dec 2016

I have tested this item successfully on 96f39a6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13367.

avatar infograf768 infograf768 - test_item - 26 Dec 2016 - Tested successfully
avatar joomla-cms-bot joomla-cms-bot - change - 26 Dec 2016
Category Administration Language & Strings Layout Administration Language & Strings Layout Front End Plugins
avatar Fedik
Fedik - comment - 26 Dec 2016

@infograf768 I made one more change, based on @ggppdk idea:
screen 2016-12-26 12 21 31 472x152

avatar infograf768
infograf768 - comment - 26 Dec 2016

I have tested this item successfully on 84ef965


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13367.

avatar infograf768 infograf768 - test_item - 26 Dec 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 26 Dec 2016

OK. Remains to see if we can make the general UI (the tabs 0 1 2 vs the Presets) more user friendly. But this I guess is for another PR.

avatar ggppdk
ggppdk - comment - 26 Dec 2016

1. Some corrections for language strings

An existing sets of the TinyMCE panel, and options for each.

Should be: Existing sets of the TinyMCE panel, and options for each.

The list of available buttons

(Maybe) should be: The list of available menus and buttons

In each Set you can add new buttons from

(Maybe) should be**: In each "set" you can add new buttons from


2. About easier configuration: (i can make a PR too)

It would be most intuitive
-- to pad+border 2nd level TABsets (like i showed on picture above) and
-- use JS to update the TAB titles, onchange of the drop-down select "Assign this layout to" (and of course on form load), to be:
"Public", "Registered" (instead of "Set 2", "Set 1")

thus the user can easily both:

  • understand what each TAB is about, (it is about configuration per VIEWing access level)
  • find the editor configuration set, of the desired access VIEWing access level without clicking them all

3. About existing tinyMCE configuration there is a simple solution to avoid problems

The existing configuration continue to be usable until you save the plugin (@Fedik correct ??)
If the above is true, just detect that there is an old configuration and display a message:

You existing configuration of tinyMCE editor is same for all access levels: public, registered, etc
We have upgraded this tinyMCE editor plugin to support 1 configuration set per access level.

After you click save your old configuration will be discarded,
Please configure the sets below and then click save

@Fedik can you do this last one ?

avatar Fedik
Fedik - comment - 26 Dec 2016
  1. Some corrections for language strings

I am not strong in English ?
@infograf768 what do you think about suggestions?

  1. About easier configuration

Not bad idea, but it make it more complicated to use the sets list in other places.
Example, I had a plan to add the option to user profile to allow to select one of existing set, so the "Set X" can be assigned to the User Y.
So I would not do what you have suggested, for now.

3 The existing configuration continue to be usable until you save the plugin

Not really, the plugin ignore an old existing configuration when render the TinyMCE,
but tries to use them on the plugin configuration form.
I think I can try to make similar thing: use existing options (which in the form) while render the TinyMCE.

avatar infograf768
infograf768 - comment - 27 Dec 2016

For the strings, I propose these changes
PLG_TINY_SET_TARGET_PANEL_DESCRIPTION="<strong>Existing sets of the TinyMCE panel, and options for each.</strong><br />In each set you can add new menus or buttons from <strong>the list of available menus and buttons</strong> or remove unneeded."
and
PLG_TINY_SET_SOURCE_PANEL_DESCRIPTION="<strong>The list of available menus and buttons.</strong><br />Use them (drag and drop) to edit or build your custom TinyMCE panel."

which will give:
screen shot 2016-12-27 at 12 20 52

avatar Fedik
Fedik - comment - 27 Dec 2016

ok, I will change the strings, this evening

avatar infograf768
infograf768 - comment - 27 Dec 2016

@Fedik
Note unrelated to this PR:
Created set Set 3 for Registered using Medium Preset modified by adding the LTR and RTL buttons OR used the existing Medium Preset tagged to registered.
Logged as Author
Using the menu item Create an article in frontend.
It is always the Advanced Preset which is displayed.
So basically, this feature does not work for me here.

avatar Fedik
Fedik - comment - 27 Dec 2016

hm, that bad, need to check more

avatar infograf768
infograf768 - comment - 27 Dec 2016

the feature is flawed. one should chose among groups and not among access which does not make sense...

avatar infograf768
infograf768 - comment - 27 Dec 2016

The problem comes from the multiple access levels one may have set on one's site.
I really think this should be redone using Users Groups instead of Access levels, i.e. using type="usergrouplist"

avatar ggppdk
ggppdk - comment - 27 Dec 2016

Similar problem a user is a member of multiple usergroups

avatar infograf768
infograf768 - comment - 27 Dec 2016

The way it is done forces to create new Access Levels AND new User Groups.
Example: most of Users menu items are set to Special.
Therefore if we let an author or an editor access these menu items, the user group they belong to has to be added to the Special Access. Even if we do not want them to use the "Special" set in TinyMCE, they will...

IN any case it does not work here, whatever I do:

Example:
Created a User Group: Author RTL as child of Author.
Created an Access Level: Author RTL with ONLY Author RTL group as viewing Access
In the editor plugin, created a new set assigned to AuthorRTL as described above

Logged in frontend as Author RTL user.

Instead of getting this

screen shot 2016-12-27 at 16 07 53

I get this

screen shot 2016-12-27 at 16 08 49

avatar infograf768
infograf768 - comment - 27 Dec 2016

@Fedik
Talked with @ggppdk a lot.
We should try to use usergroups (multiple) with priority to Set # when necessary instead of Access levels which are reserved to View and not Use and make Tiny B/C as much as possible by cheking if mode exists in the db before updating its parameters after a 3.7.0 update.
We can create a skype chat if you like.

avatar Fedik
Fedik - comment - 27 Dec 2016

I have update the strings

We should try to use usergroups

well, the idea about use "usergroup" instead of "viewlevel", sounds better,
just need to find out how to :neckbeard:
I have used "viewlevel", because old configuration also use "viewlevel" for some options, but seems it was a bad idea ?

maybe open new issue?
I will do PR tomorrow, if all will be fine

avatar infograf768
infograf768 - comment - 28 Dec 2016

@Fedik
About B/C:
My idea is to check
if ($this->params->get('mode') !== null)
then use old tiny (3.6.5 code)
and display a message if in admin to tell users to change the Tiny Settings.

	if ($app->isClient('administrator'))
	{
			$app->enqueueMessage(JText::_('PLG_TINY_OLD_TINY'), 'warning');
	}

else use new code.

avatar infograf768
infograf768 - comment - 28 Dec 2016

@Fedik
I tested successfully here modifying Tiny to be fully B/C and display a message both when using the editor in back-end (in tinymce.php) and when editing the plugin (in /layouts/plugins/editors/tinymce/field/tinymcebuilder.php)
I did it with brute force, i.e. I added the conditional in the onInit() method, then in onDisplay() method by adding in this last one the whole 3.6.5 code in one conditional, not using the conditional for each change.
It adds evidently a lot of lines into tinymce.php: 1987 versus 1122, but it is now B/C

avatar Fedik
Fedik - comment - 28 Dec 2016

@infograf768 but what you made? ? maybe add some comments to #13387
I tried to make it without the message, to not confuse user much ?

avatar infograf768
infograf768 - comment - 28 Dec 2016

Posted proposal for B/C on #13387

avatar infograf768
infograf768 - comment - 30 Dec 2016

I have tested this item successfully on acd9742

OK, may need update after #13387


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13367.

avatar infograf768 infograf768 - test_item - 30 Dec 2016 - Tested successfully
avatar Fedik
Fedik - comment - 30 Dec 2016

now I need to fix the conflict ?

avatar infograf768
infograf768 - comment - 30 Dec 2016

yep, eclipse did it for me ?

avatar Fedik
Fedik - comment - 30 Dec 2016

fixed ?

avatar infograf768
infograf768 - comment - 30 Dec 2016

I have tested this item successfully on 5c6eed1

@ggppdk

Now you can test.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13367.

avatar infograf768 infograf768 - test_item - 30 Dec 2016 - Tested successfully
avatar ggppdk
ggppdk - comment - 30 Dec 2016

I have tested this item successfully on 5c6eed1

The language strings added by this PR appear in the intended places


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13367.

avatar ggppdk ggppdk - test_item - 30 Dec 2016 - Tested successfully
avatar dgt41
dgt41 - comment - 30 Dec 2016

I have tested this item successfully on 5c6eed1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13367.

avatar dgt41 dgt41 - change - 30 Dec 2016
Status Pending Ready to Commit
avatar dgt41 dgt41 - test_item - 30 Dec 2016 - Tested successfully
avatar dgt41
dgt41 - comment - 30 Dec 2016

RTC

Thanks @Fedik


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13367.

avatar infograf768
infograf768 - comment - 2 Jan 2017

@rdeutz @wilsonge
Please merge that one too

avatar rdeutz rdeutz - change - 2 Jan 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-01-02 09:10:44
Closed_By rdeutz
avatar rdeutz rdeutz - close - 2 Jan 2017
avatar rdeutz rdeutz - merge - 2 Jan 2017

Add a Comment

Login with GitHub to post a comment