[#13363] - Normalise JInstaller type adapters storeExtension methods and rollback on package install failure
- Closed
- 23 Sep 2018
- Medium
- Build: staging
- # 13363
- Diff
- andrepereiradasilva:package-install-failure
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
Pull Request for several Issues.
Summary of Changes
This PR makes a normalizes of JInstaller type adapters storeExtension methods, and also makes all extensions rollback when installing a package with several extensions.
Also normalizes install/update storeExtensions methods of all type adapters (except language that does not seems to use it). Probably, reading the old code, there are other issues that were solved also.
Testing Instructions
This need to be tested carefully and with all install types: file, package, library, template, module, component and plugin.
A first test: Code review.
A second test:
Pre-requiste: Use this broken weblinks package (i made an error on the last extension manifest xml file so the package install fails). pkg_weblinks-broken.zip
- Without patch install the broken package, notice it fails, but when you go to extension manage some extensions of the package are installed, also notice the module is installed in modules.
- Now manualy remove the leftover extensions trough Extension manage
- Now, with patch applied install the broken package, notice it fails, but when you go to extension manage NO extensions of the package are installed, also notice the module is NOT installed in modules.
More tests:
This needs to be tested with all type of extensions: on install and on update.
Documentation Changes Required
None.
Notes
- The component storeExtension method add some hardcoded stuff reggarding to delete exisiting (that the other types don't have), not sure if needed - removed it, if needed will add it back.
- Some extension types don't process the discover_install, i didn't touch that part.
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration Language & Strings Libraries |
| Labels |
Added:
?
?
|
||
If this Issue get no Response, it will be closed at 22th September 2018.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-23 05:20:04 |
| Closed_By | ⇒ | franz-wohlkoenig |
| Closed_Date | 2018-09-23 05:20:04 | ⇒ | 2018-09-23 05:20:05 |
| Closed_By | franz-wohlkoenig | ⇒ | joomla-cms-bot |
This has been closed due to lack of response to the requests above – it can always be reopened.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13363.
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/13363
I have tested this item✅ successfully on cc517df
Without Patch: "Extension > Manage" Extensions of the package and Module are installed
With Patch: No Extensions of the package or Module are installed
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13363.