Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#13360] - Quick review on JLog

? Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
23 Dec 2016

Summary of Changes

  • Note that JLogLogger::addEntry() implementations may throw a RuntimeException
  • CS for all doc blocks
  • Use late static bindings for improved extensibility
  • Flip an if/else

Testing Instructions

Review

Documentation Changes Required

N/A

avatar mbabker mbabker - open - 23 Dec 2016
avatar mbabker mbabker - change - 23 Dec 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Dec 2016
Category ⇒ Libraries
avatar Hackwar
Hackwar - comment - 23 Dec 2016

I have tested this item ✅ successfully on 5752dbe

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13360.

avatar Hackwar Hackwar - test_item - 23 Dec 2016 - Tested successfully
avatar wilsonge wilsonge - reference | 7002402 - 23 Dec 16
avatar wilsonge wilsonge - merge - 23 Dec 2016
avatar wilsonge wilsonge - close - 23 Dec 2016
avatar wilsonge wilsonge - change - 23 Dec 2016
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-12-23 22:00:30
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 23 Dec 2016
avatar wilsonge wilsonge - merge - 23 Dec 2016
avatar wilsonge wilsonge - change - 23 Dec 2016
Milestone Added:
avatar mbabker mbabker - head_ref_deleted - 24 Dec 2016

Add a Comment

Login with GitHub to post a comment