[#13348] - [com_fields] Fixing "Search - Content" plugin and make it work with fields
- Fixed in Code Base
- 27 Dec 2016
- Medium
- Build: staging
- # 13348
- Diff
- Bakual:FixSearch
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #13291 and #13302 (comment).
While trying to remove the GROUP_CONCAT (that isn't supported by non-MySQL DBs) from the "Content - Search" plugin, I saw it is actually badly broken.
Try to search for an article when there are no valid fields (eg no published, public available fields). It will not show the article.
Summary of Changes
Rewrites the query so it doesn't use an INNER JOIN over the fields table. Also rewrote the conditionals so they are also fine with a NULL value (since we now have a LEFT JOIN).
The GROUP_CONCAT is replaced by a value lookup per item later down.
Testing Instructions
- Try the search plugin (the classic one, not Smart Search / Finder)
- Make sure searching for articles text, metadata and fields works and doesn't give duplicate items as result
Known Limitation
Field values coming from list types (eg selects and checkboxes) will not be searchable because we store the value and not the text of that selection.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
| Title |
|
||||||
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Title |
|
||||||
| Labels |
Added:
?
|
||||||
I have tested this item
On MySQL and PostgreSQL.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13348.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13348.
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-27 21:45:27 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Hi,
Yesterday, I found that search is not longer working. Please, check #13569
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13348.
I have tested this item✅ successfully on 468abb4
tested on postgresql
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13348.