Feeling Lucky
?
[#13316] - [com_fields] Merge FieldsHelperInternal into FieldsHelper
- Fixed in Code Base
- 27 Dec 2016
- Medium
- Build: staging
- # 13316
- Diff
- Bakual:MergeFieldsHelpers
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Currently we have two helpers for com_fields: FieldsHelper and FieldsHelperInternal. They require eachother and one method (canEditFieldValue) even exists in both helpers.
Summary of Changes
This PR proposes to delete the FieldsHelperInternal class and moves the two unqie methods in it to FieldsHelper
Testing Instructions
- Make sure submenus for the components still work.
- Test editing values still work according to set ACL
- Test that the gallery fields plugin works as before.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
| Title |
|
||||||
| Title |
|
||||||
ralain
- comment
- 23 Dec 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13316.
| Status | Pending | ⇒ | Ready to Commit |
jeckodevelopment
- comment
- 23 Dec 2016
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13316.
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-27 21:45:05 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 49bbc0e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13316.