[#13310] - More type-safe comparisons in site/templates
- Fixed in Code Base
- 10 Jun 2017
- Medium
- Build: staging
- # 13310
- Diff
- frankmayer:more-type-safe-comparisons-in-site-templates
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Summary of Changes
- More type-safe comparisons in site/templates
The changes in this PR should be fairly easy to review. They are only type safe int or bool comparisons. This PR is done, so the batch PR #12233 can become a little lighter and easier to review. In hope that this will get merged quickly so further work can be done without conflicting with other PRs. ;)
Testing Instructions
None, should not change behavior
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
The quick points:
- Good coding practice
- More strict typing = less error prone code
- Faster processing of such comparisons
There is lots of info on the web on this matter.
In general, type safety should be preferred, otherwise you run into a lot of funny PHP quirks.
Essentially, '0' == 0 == false == null in PHP with loose typing, same with '1' == 1 == true.
Newer PHP versions also start spitting errors when you give non-numeric types (only integer and float are numeric) to be processed for arithmetic operations, older versions were a little less restrictive and would try to do math on a string representation on the value.
I have tested this item
On code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13310.
I have tested this item
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13310.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-10 18:50:39 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Could you please explain why we need all these type-safe comparisons?