Feeling Lucky
?
[#13307] - Container added to all batch modals
- Fixed in Code Base
- 2 Jan 2017
- Medium
- Build: staging
- # 13307
- Diff
- ciar4n:batch-modal
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #13305 .
Summary of Changes
Adds a container to the batch modals to stop content from been flush to the modal edges.
Testing Instructions
Apply patch and check all batch modals.
Before Patch
After Patch
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_categories com_contact com_content com_fields com_menus com_modules com_newsfeeds com_redirect com_tags com_users Templates (admin) |
coolcat-creations
- comment
- 29 Dec 2016
Spaces are correct now, but still can´t access bottom of the list: (Cache is cleared)
coolcat-creations
- comment
- 29 Dec 2016
I have tested this item
see my screenshot from custom fields batch process for details.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13307.
| Labels |
Added:
?
|
||
ciar4n
- comment
- 29 Dec 2016
Thank you @cpfeifer & @coolcat-creations. These issues have been amended....
ralain
- comment
- 29 Dec 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13307.
jeckodevelopment
- | Milestone |
Added: |
||
| Milestone |
Removed: |
||
dgt41
- comment
- 29 Dec 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13307.
| Status | Pending | ⇒ | Ready to Commit |
dgt41
- comment
- 29 Dec 2016
RTC
Thanks @ciar4n
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13307.
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-02 00:56:46 |
| Closed_By | ⇒ | rdeutz |
Tested. You missed one small detail in the module manager administrator/components/com_modules/views/modules/tmpl/default_batch_body.php
Line 34, the COM_MODULES_BATCH_TIP paragraph should go inside the container
Otherwise awesome. I was going to do this but you beat me to it :)