[#13302] - [com_fields] Remove GroupConcat from fields model
- Fixed in Code Base
- 27 Dec 2016
- Medium
- Build: staging
- # 13302
- Diff
- Bakual:RemoveGroupConcat
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
When normalising the fields table (moving assigned_cat_ids to own table #__fields_categories) I introduced the use of a "GROUP_CONCAT". However that only works in MySQL and not in PostgreSQL and MSSQL. @alikon created a PR to port the group concat feature to PostgreSQL but it would still need a solution for MSSQL.
When looking why we need it I found that it is only used for the fiels list manager to show the categories:
Summary of Changes
This PR proposes to remove that information from the list manager (it's obviously still in the form itself) which removes the need for that GROUP_CONCAT. On the other hand it allows to add a filter for those categories
Testing Instructions
- Apply PR and test that assigning categories to a field still works.
- Test filtering by category
- Test that fields with assigned categories only show up in items (eg articles) with that category assigned both when displaying and editing.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields Language & Strings |
We will have to do separate queries to fetch that. Since it's only used in backend I see no issues with the potential performance impact (they are light queries anyway).
I can add it back hopefuly later today.
Thanks.
| Labels |
Added:
?
?
|
||
Added back the categories using a new helper method.
we still have a GROUP_CONCAT() in search content plugin
https://github.com/joomla/joomla-cms/pull/13291/files#diff-b32bbae639a4113309650b03c2b09ba1R173
I have tested this item
tested with postgresql
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13302.
Yep, I know about the content one. Didn't have the time yet to look at it. Have to play with search a bit tomorrow
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13302.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
RTC, thanks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13302.
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-27 21:44:03 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
It works, but I still would like to have the information about assigned categories in the list view. I use this information quite often on my production sites with DPFields.