? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
20 Dec 2016

Currently, formfields from components aren't registered as custom fields. The code is actually there to look them up but it fails.

Summary of Changes

Instead of just adding the path to the internal array, it now properly registers the path in the form. This way JFormHelper::loadFieldClass() a few lines below will actually find the field.

Testing Instructions

You should see additional fields if an extension has custom ones that implement JFormDomfieldinterface
In core, we don't have that case but you can try it by adding implements JFormDomfieldinterfaceto eg this line: https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_users/models/fields/levels.php#L17
This should give you a new formfield "level" in com_users fields.

Documentation Changes Required

None

avatar Bakual Bakual - open - 20 Dec 2016
avatar Bakual Bakual - change - 20 Dec 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Dec 2016
Category Administration com_fields
avatar Bakual Bakual - change - 20 Dec 2016
Title
Register extension path for formfield lookup in com_fields
[com_fields] Register extension path for formfield lookup in com_fields
avatar Bakual Bakual - edited - 20 Dec 2016
avatar laoneo
laoneo - comment - 23 Dec 2016

I guess this one becomes obsolete, when #13319 is accepted as all the logic is moved to plugins then?

avatar Bakual
Bakual - comment - 23 Dec 2016

Yep, that's true. Closing in favor of the plugins ?

avatar Bakual Bakual - change - 23 Dec 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-12-23 10:12:14
Closed_By Bakual
Labels Added: ?
avatar Bakual Bakual - close - 23 Dec 2016

Add a Comment

Login with GitHub to post a comment