? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
19 Dec 2016

Pull Request for Issue #13246 (comment) .
see #13246 and #13285 and #13308

Summary of Changes

  • added the postgresql GROUP_CONCAT() translation
  • fixed group by
  • fixed typecast on join

How to test

  • content search plugin work as before
  • com_fields work as before

To do

  • add the mssql translation
avatar alikon alikon - open - 19 Dec 2016
avatar alikon alikon - change - 19 Dec 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Dec 2016
Category Postgresql Libraries
avatar alikon alikon - change - 19 Dec 2016
The description was changed
avatar alikon alikon - edited - 19 Dec 2016
avatar alikon alikon - change - 19 Dec 2016
The description was changed
avatar alikon alikon - edited - 19 Dec 2016
avatar alikon alikon - change - 19 Dec 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 19 Dec 2016
Category Postgresql Libraries Administration com_fields Libraries Postgresql
avatar joomla-cms-bot joomla-cms-bot - change - 19 Dec 2016
Category Postgresql Libraries Administration com_fields Administration com_fields Libraries Postgresql Front End Plugins
avatar alikon alikon - change - 19 Dec 2016
The description was changed
avatar alikon alikon - edited - 19 Dec 2016
avatar alikon alikon - change - 19 Dec 2016
Title
WIP [sql] - GROUP_CONCAT() portable other than mysql
[sql] - GROUP_CONCAT() portable other than mysql
avatar alikon alikon - edited - 19 Dec 2016
avatar alikon alikon - change - 19 Dec 2016
The description was changed
avatar alikon alikon - edited - 19 Dec 2016
avatar alikon alikon - change - 20 Dec 2016
The description was changed
avatar alikon alikon - edited - 20 Dec 2016
avatar ralain
ralain - comment - 20 Dec 2016

I'm seeing another problem in the Search plugin even without this PR applied. If no custom fields are defined in com_content nothing is returned when doing a search.

avatar laoneo
laoneo - comment - 21 Dec 2016

@ralain did you proof that or is it only an assumption?

avatar ralain
ralain - comment - 21 Dec 2016

@laoneo Stumbled on it by accident during fields/search testing, not an assumption. With the custom field my test article would be returned from the search. Without the a field, or with the field unpublished, it would not.

avatar laoneo
laoneo - comment - 21 Dec 2016

I'v deleted all my fields and made sure that all fields tables are empty. Then I created an article with demo in the title. When I search in the default search module for demo, then the article shows up. If there is really a bug please open a new issue and prefix it with [com_fields]. Thanks.

avatar ralain
ralain - comment - 21 Dec 2016

I might be mistaken, will check again tonight.

avatar alikon
alikon - comment - 21 Dec 2016

should be another issue related to non-mysql DB, i'll investigate on it...

avatar laoneo
laoneo - comment - 21 Dec 2016

Thank you guys for taking so much care of Postgres and MSSql implementation, really appreciated!

avatar ralain
ralain - comment - 21 Dec 2016

I have tested this item successfully on 7f4a852

Tested on MySQL and PostgreSQL. I assume MSSQL still has problems, but it wouldn't be because of this PR.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13291.

avatar ralain ralain - test_item - 21 Dec 2016 - Tested successfully
avatar Bakual
Bakual - comment - 23 Dec 2016

If #13302 and #13348 are merged, we don't have a need anymore for this PR (at least not in core).

avatar alikon
alikon - comment - 23 Dec 2016

yes....,
after merge, i'll redo to only add the postgresql translation for GROUP_CONCAT()

avatar Bakual
Bakual - comment - 27 Dec 2016

Both my PRs are merged now. So no GROUP_CONCAT is used anymore in core to my knowledge.
So do we still want to add this here or do we just close it? We're still missing the implementation or MSSQL anyway.

avatar alikon
alikon - comment - 30 Dec 2016

ok, i'm closing this one
but i'll open a new one cause maybe some 3dp extensions could use it

avatar alikon alikon - change - 30 Dec 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-12-30 10:51:54
Closed_By alikon
avatar alikon alikon - close - 30 Dec 2016

Add a Comment

Login with GitHub to post a comment