Feeling Lucky
?
?
[#13284] - PostgreSQL - return the same string each time of call __toString() on update query with join
- Fixed in Code Base
- 14 Jan 2017
- Medium
- Build: staging
- # 13284
- Diff
- csthomas:postgresql_update_query
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue:
- Update (with join) query (JDatabaseQueryPostgresql) on each call method
__toString()generates different string.
Summary of Changes
- Fix PostgreSQL update query to return the same string each time of call method
__toString() - this PR become from #12839
Testing Instructions
Test by travis.
Code review.
Documentation Changes Required
N/A
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Postgresql Libraries Unit Tests |
csthomas
- comment
- 19 Dec 2016
On joomla that uses postgreSQL:
php > $db = JFactory::getDbo();
php > $q = $db->getQuery(true)->update('#__content a')->set('hits = 1')->innerJoin('#__categories c ON a.catid = c.id')->where('c.id = 5');
php > echo $q;
UPDATE #__content a
SET hits = 1
FROM #__categories c
WHERE c.id = 5 AND a.catid = c.id
php > echo $q;
UPDATE #__content a
SET hits = 1
FROM #__categories c,#__categories c
WHERE c.id = 5 AND a.catid = c.id AND a.catid = c.id
php > echo $q;
UPDATE #__content a
SET hits = 1
FROM #__categories c,#__categories c,#__categories c
WHERE c.id = 5 AND a.catid = c.id AND a.catid = c.id AND a.catid = c.id| Title |
|
||||||
| Title |
|
||||||
waader
- comment
- 27 Dec 2016
I have tested this item
I got always the same malformed query and this patch corrected the problem. Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13284.
alikon
- comment
- 5 Jan 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13284.
csthomas
- comment
- 5 Jan 2017
Thanks a lot for the tests.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
jeckodevelopment
- comment
- 5 Jan 2017
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13284.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-14 23:58:22 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 14 Jan 2017
Nice catch!! Thanks :)
Can you give an example of a query that returns a different string on every call ?
which part of the query is different ?