[#13281] - [com_fields] Change the description field of the group to the default editor layout
- Closed
- 23 Jul 2017
- Medium
- Build: staging
- # 13281
- Diff
- bembelimen:com_fields-desc
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
Summary of Changes
At the moment the description field of a group is a textarea. In Joomla! in general all description fields are editor fields. This PR changes the field to an editor field
Testing Instructions
Create or edit a field group.
Before: there is a textarea field
After: there is an editor field + the Joomla! text filter parameters are applied
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration com_fields |
| Title |
|
||||||
| Title |
|
||||||
We could allow HTML there?
I have tested this item
Test OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13281.
I have tested this item
A warning blocking the Save operation:
**
Warning
Invalid field: JFIELD_RULES_LABEL**
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13281.
We could allow HTML there?
We probably don't allow it for a reason
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13281.
I have tested this item
Test OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13281.
@joomla/cms-maintainers Needs a decision here.
Changing this to an editor doesn't change anything as long as fieldset (tab) descriptions filter any HTML tags out. So that would would need to be changed as well but I don't know why there is filtering to begin with. I just assume there was a reason for it.
I have tested this item
When adding HTML tags to the description trough the editor, then the tags are stripped in the edit form tabs.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13281.
@bembelimen any intention to fix this PR?
Would be nice to have an editor here @bembelimen
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13281.
| Status | Pending | ⇒ | Needs Review |
Other than we should have an editor here. What is the added value of having an editor?
| Status | Needs Review | ⇒ | Information Required |
If this PR get no Response, it will be closed at 23th July 2017.
The question is: should there be an editor field at all? As I read here, some say yes, some say no... so? If all say "yes", I can fix it.
asking @production Departement
I will go trough the git history next week to see if there is a reason why it is plain text only atm.
I guess we can't change it because the description gets translated first and then escaped. This would lead to a situation that the HTML code will be shown as output. Relevant line is here https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/edit/params.php#L119. I wen't back in history and this code exists over 4 years like that. So it would probably lead to a BC break when we stop escaping the output. It's a minor one but it will be one at the end. @Bakual what do you think?
Personally I don't see a reason to add HTML to the fieldset description.
In the end I think we end up with more issues if we allow it.
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-23 08:34:38 |
| Closed_By | ⇒ | franz-wohlkoenig |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/13281
closed as stated above.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13281.
That's intended to be a textarea. Since the text is used in fieldset (tabs) descriptions where all tags are stripped anyway, it doesn't make sense to have a wysiwyg editor field here. It would only be confusing if you add eg an image to the description and then don't see it in the form.