[#13273] - Logout code needs to account for shared_session parameter
- Fixed in Code Base
- 21 Dec 2016
- Medium
- Build: staging
- # 13273
- Diff
- mbabker:logout-fixes
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue N/A
Summary of Changes
The logout code has checks for a client ID that needs to be accounted for. Make those adaptions.
Testing Instructions
Logging out should work correctly. You may need #13075 applied to be able to create a scenario where logout is not working right. The branch at https://github.com/mbabker/joomla-cms/tree/logout-database-sessions combines these two PRs for convenience.
Documentation Changes Required
N/A
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_login com_users Front End Libraries Plugins |
| Labels |
Added:
?
|
||
I have tested this item
The same as above.
Tested both #13273 and #13075 applied in the patchtester.
Tested with shared and non shared session both login and logout from admin and site client
all worked fine.
This is not related.
After logout from front page component button I was redirected to localhost/ instead localhost/~user/joomla/
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13273.
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-21 20:41:53 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
Merged Thanks!
cpfeifer
-
I have tested this item✅ successfully on 5c1996f
Tested both #13273 and #13075 applied in the patchtester.
Tested with shared and non shared session both login and logout from admin and site client
all worked fine. so works as described
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13273.