? Success

User tests: Successful: Unsuccessful:

avatar frankmayer
frankmayer
18 Dec 2016

Summary of Changes

  • Type safe string comparison of strings only, in plugins

This PR is part of a set to try to separate some of the changes done in one of my previous batch PR's for the plugins directory, which is still on hold (#12228).
Once the new set is merged completely, it will hopefully reduce the changes in that PR, so it can be reviewed easier and finally be merged.

The changes in this PR should be very easy to review, as they are only string comparisons. In hope that this will get merged quickly. ;)

Note: Don't bother if some possible changes are missing or could be differently written. They are probably in the batch PR , that this one references. As soon as this set of sub PR's is merged, the batch PR will have its conflicts resolved and should be a lot easier to review and finally get merged.

Testing Instructions

None, should not change behavior

Documentation Changes Required

None.

avatar frankmayer frankmayer - open - 18 Dec 2016
avatar frankmayer frankmayer - change - 18 Dec 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Dec 2016
Category Front End Plugins
avatar frankmayer frankmayer - change - 18 Dec 2016
The description was changed
avatar frankmayer frankmayer - edited - 18 Dec 2016
avatar frankmayer frankmayer - change - 18 Dec 2016
The description was changed
avatar frankmayer frankmayer - edited - 18 Dec 2016
avatar wilsonge wilsonge - reference | 5044642 - 19 Dec 16
avatar wilsonge wilsonge - merge - 19 Dec 2016
avatar wilsonge wilsonge - close - 19 Dec 2016
avatar wilsonge wilsonge - change - 19 Dec 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-12-19 15:14:59
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 19 Dec 2016
avatar wilsonge wilsonge - merge - 19 Dec 2016
avatar wilsonge wilsonge - change - 19 Dec 2016
Milestone Added:
avatar frankmayer frankmayer - head_ref_deleted - 25 Dec 2016

Add a Comment

Login with GitHub to post a comment