Feeling Lucky
?
[#13249] - Moved some things outside loops, project-wide.
- Fixed in Code Base
- 11 Jun 2017
- Medium
- Build: staging
- # 13249
- Diff
- frankmayer:move-various-things-out-of-loops
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
- Moved some things outside loops.
Testing Instructions
None, should not change behavior
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media Libraries Front End Plugins |
| Labels |
Added:
?
|
||
| Category | Administration com_media Libraries Front End Plugins | ⇒ | Administration com_media Libraries |
| Status | Pending | ⇒ | Needs Review |
andrepereiradasilva
- comment
- 1 Jun 2017
I have tested this item
On code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13249.
frankmayer
- comment
- 9 Jun 2017
One code review test and multiple approvals. Can we please RTC this? Thank you
Quy
- comment
- 9 Jun 2017
I have tested this item
Code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13249.
| Status | Needs Review | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 10 Jun 2017
RTC after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-11 11:33:30 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Any specific reason, this has not been merged yet?
The code-changes in question were approved my multiple reviewers.