[#13246] - [com_fields] Normalise data structure for assigned categories
- Fixed in Code Base
- 19 Dec 2016
- Medium
- Build: staging
- # 13246
- Diff
- Bakual:NormaliseFieldCatids
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #13222 .
Currently, the assigned category ids are stored as a coma separated string into the #__fields table.
As Hannes pointed out in the referenced issue that is not optimal.
Summary of Changes
This PR removes that data field from the #__fields table and moves it to a cross-reference table #__fields_categories.
Testing Instructions
- Create and edit fields and assign categories to them. Make sure they save correctly. Also try to remove them again so they show "All" again.
- Test that the fields show up as expected in the article/user/contact edit forms and frontend views.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin Postgresql com_fields Installation |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13246.
Syntax error on PostgreSQL when attempting to access the fields view:
Tried changing GROUP_CONCAT(fc.category_id SEPARATOR ',') to STRING_AGG(fc.category_id::text, ',') and executing the query in pgAdmin:
So GROUP_CONCAT doesn't work in PostgreSQL? That's interesting since we already use it in the content search plugin. I guess that one doesn't work as well then?
I have to see if we really need that assigned_cat_ids or if we can do that in a different way. Maybe an own query is better anyway.
It would appear not. Just tried search and that fails, too.
Can you open a new issue for the search? I will try to solve it here in a different way then.
Yep, will do.
I have tested this item
Test OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13246.
rdeutz
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-19 16:33:05 |
| Closed_By | ⇒ | rdeutz |
| Milestone |
Added: |
||
we need to do a couple of fix for postgres
- GROUP_CONTACT() translation
- group by
cpfeifer
-
This should also remove the need to port "FIND_IN_SET" to non-MySQL databases like done in #12642