? Success

User tests: Successful: Unsuccessful:

avatar frankmayer
frankmayer
16 Dec 2016

Summary of Changes

  • Simplify ternary operation using elvis operator
  • Remove unneeded parentheses

This PR is part of a set to try to separate some of the changes done in one of my previous batch PR's for the templates directory, which is still on hold (#12233).
Once the new set is merged it will hopefully reduce the changes in that PR, so it can be reviewed easier and finally be merged.

The changes in this PR are only of two types and should be fairly easy to review. In hope that this will get merged quickly. ;)

Testing Instructions

None, should not change behavior

Documentation Changes Required

None.

avatar frankmayer frankmayer - open - 16 Dec 2016
avatar frankmayer frankmayer - change - 16 Dec 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Dec 2016
Category Front End Templates (site)
avatar wilsonge wilsonge - change - 18 Dec 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-12-18 11:27:39
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 18 Dec 2016
avatar wilsonge wilsonge - merge - 18 Dec 2016
avatar wilsonge wilsonge - reference | a9d7713 - 18 Dec 16
avatar wilsonge wilsonge - merge - 18 Dec 2016
avatar wilsonge wilsonge - close - 18 Dec 2016
avatar wilsonge wilsonge - change - 18 Dec 2016
Milestone Added:
avatar frankmayer frankmayer - head_ref_deleted - 25 Dec 2016

Add a Comment

Login with GitHub to post a comment