Feeling Lucky
?
[#13241] - Various changes in libraries legacy
- Fixed in Code Base
- 18 Dec 2016
- Medium
- Build: staging
- # 13241
- Diff
- frankmayer:various-changes-in-libraries-legacy
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
- Inline one-time use variables
- Removed unnecessary ternary operators
- Merge unset() calls
- Use modern day type-casting
- This can be replaced with type-casting
This PR is part of a set to try to separate some of the changes done in one of my previous batch PR's for the libraries/legacy directory, which is still on hold (#12220).
Once the new set is merged it will hopefully reduce the changes in that PR, so it can be reviewed easier and finally be merged.
The changes in this PR should be fairly easy to review. In hope that this will get merged quickly. ;)
Testing Instructions
None, should not change behavior
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
anibalsanchez
- comment
- 18 Dec 2016
I have tested this item
Test OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13241.
| Status | Pending | ⇒ | Ready to Commit |
jeckodevelopment
- comment
- 18 Dec 2016
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13241.
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-18 20:25:50 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
cpfeifer
-
I have tested this item✅ successfully on cf060f6
Done code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13241.