Feeling Lucky
?
[#13238] - Various changes in libraries/cms
- Fixed in Code Base
- 9 Jun 2017
- Medium
- Build: staging
- # 13238
- Diff
- frankmayer:various-changes-in-libraries-cms
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
- Use modern day type casting
- Simplify ternary operation
- Merge unset() calls
This PR is part of a set to try to separate some of the changes done in one of my previous batch PR's for the libraries/cms directory, which is still on hold (#12171).
Once the new set is merged it will hopefully reduce the changes in that PR, so it can be reviewed easier and finally be merged.
The changes in this PR should be fairly easy to review. In hope that this will get merged quickly. ;)
Testing Instructions
None, should not change behavior
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
Quy
- comment
- 29 May 2017
I have tested this item
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13238.
andrepereiradasilva
- comment
- 31 May 2017
I have tested this item
on code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13238.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 31 May 2017
RTC after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-09 21:28:09 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Conflicts resolved. Pls check and merge.