Feeling Lucky
?
[#13234] - Simplify some ternary operations using elvis operator and remove unnecessary parentheses in libraries/cms
- Fixed in Code Base
- 5 Feb 2017
- Medium
- Build: staging
- # 13234
- Diff
- frankmayer:elvis-and-unneeded-parentheses-in-libraries-cms
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary of Changes
- Simplify ternary operation with elvis operator
- Remove unnecessary parentheses
This PR is part of a set to try to separate some of the changes done in one of my previous batch PR's for the libraries/cms directory, which is still on hold (#12171).
Once the new set is merged it will hopefully reduce the changes in that PR, so it can be reviewed easier and finally be merged.
The changes in this PR are only of two types andshould be fairly easy to review. In hope that this will get merged quickly. ;)
Testing Instructions
None, should not change behavior
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
?
|
||
jeckodevelopment
- comment
- 18 Dec 2016
@frankmayer we need at least 2 successful tests
frankmayer
- comment
- 12 Jan 2017
@jeckodevelopment Due to the nature of the changes, this should only be code review if automatic tests pass already.
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-05 15:23:47 |
| Closed_By | ⇒ | wilsonge |
Conflicts resolved. Can we merge this, if OK?