?
avatar Hackwar
Hackwar
15 Dec 2016

The new field feature added at least 3 methods to JFormField and maybe there are even more. Neither of those methods has unittests. We should actually have unittests for both the methods in /libraries and the fields plugin, since these interact with third party code, similar to the finder code. But I could live without covering the plugins code. The methods in /libraries are a must however.

This is part of a code review of the fields feature. See #13222, #13223, #13224, #13225 and other connected issues.

avatar Hackwar Hackwar - open - 15 Dec 2016
avatar joomla-cms-bot joomla-cms-bot - change - 15 Dec 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 15 Dec 2016
avatar Bakual Bakual - change - 15 Dec 2016
Title
Fields: New methods in library have no unittests
[com_fields] New methods in library have no unittests
avatar Bakual Bakual - change - 15 Dec 2016
Title
Fields: New methods in library have no unittests
[com_fields] New methods in library have no unittests
avatar Bakual Bakual - edited - 15 Dec 2016
avatar laoneo
laoneo - comment - 30 Dec 2016

The new functions in JFormField will get removed with pr #13319. So I guess we can close this one then.

avatar Bakual Bakual - change - 1 Jan 2017
Status New Closed
Closed_Date 0000-00-00 00:00:00 2017-01-01 17:02:02
Closed_By Bakual
avatar Bakual Bakual - close - 1 Jan 2017
avatar Bakual
Bakual - comment - 1 Jan 2017

Closing as we have a PR that deals with it.

@Hackwar If you feel it is still valid, feel free to reopen.

Add a Comment

Login with GitHub to post a comment