?
avatar Hackwar
Hackwar
15 Dec 2016

The groups feature of the fields component should be implemented by using com_categories. Right now, this is simply duplicating the code of com_categories, including the database structure. Yes, the groups code currently has less features than the categories code, which is another reason to use that instead. Use the categories table with a proper context and you will already be able to nest the groups arbitrarily deep, which will be a requested feature the moment this gets released.

This is part of a code review of the fields feature. See #13222 and other connected issues.

avatar Hackwar Hackwar - open - 15 Dec 2016
avatar joomla-cms-bot joomla-cms-bot - change - 15 Dec 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 15 Dec 2016
avatar Bakual
Bakual - comment - 15 Dec 2016

Nah, it was categories and had issues. We changed to to field groups.
See #13019

avatar Hackwar
Hackwar - comment - 15 Dec 2016

I disagree. DRY applies here. See my other comment in #13222

avatar Bakual
Bakual - comment - 15 Dec 2016

I understand you, but there were to many issues and having com_fields specific code in com_categories is not acceptable. Also com_categories really is overkill for what we need here.
That's why it has been decided by PLT/Maintainers to change it.

avatar laoneo
laoneo - comment - 15 Dec 2016

@Hackwar I was also fighting for it to leave it as categories (#12693 and #12681). But there is one valid argument against the use of categories. When com_fields will grow in the future to become really powerful then it can hinder us when we depend on com_categories.

avatar Bakual Bakual - change - 15 Dec 2016
Title
Fields: Groups should be categories
[com_fields] Groups should be categories
avatar Bakual Bakual - change - 15 Dec 2016
Title
Fields: Groups should be categories
[com_fields] Groups should be categories
avatar Bakual Bakual - edited - 15 Dec 2016
avatar infograf768 infograf768 - change - 16 Dec 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-12-16 10:45:17
Closed_By infograf768
avatar joomla-cms-bot joomla-cms-bot - change - 16 Dec 2016
Closed_Date 2016-12-16 10:45:17 2016-12-16 10:45:18
Closed_By infograf768 joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 16 Dec 2016
avatar joomla-cms-bot
joomla-cms-bot - comment - 16 Dec 2016
avatar joomla-cms-bot joomla-cms-bot - close - 16 Dec 2016
avatar infograf768
infograf768 - comment - 16 Dec 2016

Closing as the decision has been taken.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13223.

Add a Comment

Login with GitHub to post a comment