[#13221] - Read cURL header_size to determine header size
- Fixed in Code Base
- 5 Feb 2017
- Medium
- Build: staging
- # 13221
- Diff
- Bakual:GetHeaderSizeFromHeaderSize
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
This PR tries to improve the header/body separation for cURL response objects.
Since the header count can vary (redirects, proxy, ...) there is currently code which takes into acounts possible redirects. However that fails if there are additional headers due to other enviroment (eg a proxy).
When I tried to fix it in my case I found that there is a header_size already present in the cURL info.
Summary of Changes
This PR changes the way the header is determined by using the cURL info "header_size". If that for some reason isn't present it falls back to the old way. I honestly doon't know if that info is always available or not, so I just kept the fallback case.
Testing Instructions
The simplest way to test this is probably searching for updates in the Extension manager. If you don't see an error message that the update server wasn't responding or the XML couldn't be parsed or similar, then it should be fine.
If you actually see any updates, then it means it works for sure.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
I have tested this item
I have testet it with JCE
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13221.
testet on #JC17DE
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13221.
zero-24
- | Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-05 22:38:22 |
| Closed_By | ⇒ | wilsonge | |
| Labels | |||
I have tested this item✅ successfully on 9fe92e0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13221.