? Success

User tests: Successful: Unsuccessful:

avatar frankmayer
frankmayer
14 Dec 2016

Summary of Changes

  • Removed one-time use variable
  • Merged unset calls
  • Removed obvious variants from ternary operation
  • Used short syntax for applied operation

This PR is part of a set to try to separate some of the changes done in one of my previous batch PR's for plugins, which is still on hold (#12228).
Once the new set is merged it will hopefully reduce the changes in that PR, so it can be reviewed easier and finally be merged.

The changes in this PR are few and very easy to review. In hope that this will get merged quickly. ;)

Testing Instructions

None, should not change behavior

Documentation Changes Required

None.

avatar frankmayer frankmayer - open - 14 Dec 2016
avatar frankmayer frankmayer - change - 14 Dec 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Dec 2016
Category Front End Plugins
avatar wilsonge wilsonge - change - 18 Dec 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-12-18 11:24:23
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 18 Dec 2016
avatar wilsonge wilsonge - merge - 18 Dec 2016
avatar wilsonge wilsonge - reference | faced55 - 18 Dec 16
avatar wilsonge wilsonge - merge - 18 Dec 2016
avatar wilsonge wilsonge - close - 18 Dec 2016
avatar wilsonge wilsonge - change - 18 Dec 2016
Milestone Added:
avatar cpfeifer cpfeifer - reference | fb3e6ba - 22 Dec 16
avatar frankmayer frankmayer - head_ref_deleted - 25 Dec 2016

Add a Comment

Login with GitHub to post a comment