Feeling Lucky
?
[#13199] - Changes on continue statements
- Fixed in Code Base
- 18 Dec 2016
- Medium
- Build: staging
- # 13199
- Diff
- frankmayer:changes-on-continue-statements
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary of Changes
- Remove unnecessary 'continue' function
- Change 'continue' so that it breaks out of the 'switch', as there is no need to compare against the rest.
Testing Instructions
None, should not change behavior
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate Modules Front End |
| Labels |
Added:
?
|
||
anibalsanchez
- comment
- 18 Dec 2016
I have tested this item
Test OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13199.
| Status | Pending | ⇒ | Ready to Commit |
jeckodevelopment
- comment
- 18 Dec 2016
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13199.
| Milestone |
Added: |
||
| Labels |
Added:
?
|
||
| Category | Administration com_joomlaupdate Modules Front End | ⇒ | Modules Front End |
rdeutz
- comment
- 18 Dec 2016
yeah good to go, had the check twice but continue and break are the same in a switch, break is more common.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-18 22:05:47 |
| Closed_By | ⇒ | rdeutz |
cpfeifer
-
I have tested this item✅ successfully on 114a19a
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13199.