? Success

User tests: Successful: Unsuccessful:

avatar frankmayer
frankmayer
13 Dec 2016

Summary of Changes

  • Simplified some ternary operations with elvis operator

This PR is part of a set to try to separate some of the changes done in some of my previous batch PR's for site/components, which are still on hold (#12290, #12292, #12293, #12294).

Testing Instructions

None, should not change behavior

Documentation Changes Required

None.

avatar frankmayer frankmayer - open - 13 Dec 2016
avatar frankmayer frankmayer - change - 13 Dec 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Dec 2016
Category Front End com_ajax com_config com_contact com_content com_fields com_tags com_users
avatar andrepereiradasilva
andrepereiradasilva - comment - 13 Dec 2016

I have tested this item successfully on 414f378

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13185.

avatar andrepereiradasilva andrepereiradasilva - test_item - 13 Dec 2016 - Tested successfully
avatar alikon
alikon - comment - 13 Dec 2016

I have tested this item successfully on 414f378

on code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13185.

avatar alikon alikon - test_item - 13 Dec 2016 - Tested successfully
avatar jeckodevelopment jeckodevelopment - change - 13 Dec 2016
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 13 Dec 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13185.

avatar jeckodevelopment jeckodevelopment - change - 13 Dec 2016
Milestone Added:
avatar frankmayer frankmayer - change - 14 Dec 2016
Labels Added: ?
avatar frankmayer
frankmayer - comment - 14 Dec 2016

Conflicts resolved. Could you pls review and merge if OK?

avatar wilsonge wilsonge - reference | 471db2f - 15 Dec 16
avatar wilsonge wilsonge - merge - 15 Dec 2016
avatar wilsonge wilsonge - close - 15 Dec 2016
avatar wilsonge wilsonge - change - 15 Dec 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-12-15 17:59:24
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 15 Dec 2016
avatar wilsonge wilsonge - merge - 15 Dec 2016
avatar frankmayer frankmayer - head_ref_deleted - 15 Dec 2016
avatar cpfeifer cpfeifer - reference | fb3e6ba - 22 Dec 16

Add a Comment

Login with GitHub to post a comment