Feeling Lucky
?
[#13183] - Unnecessary double quotes in site components
- Fixed in Code Base
- 14 Dec 2016
- Medium
- Build: staging
- # 13183
- Diff
- frankmayer:unnecessary-double-quotes-in-site-components
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
- Replaced unnecessary double quotes in site/components
- Removed one or two whitespaces at EOLs (sorry, couldn't resist)
- Inserted a line before if statements where I stumbled upon (sorry, couldn't resist)
This PR is part of a set to try to separate some of the changes done in some of my previous batch PR's for site/components, which are still on hold (#12290, #12292, #12293, #12294).
Testing Instructions
None, should not change behavior
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_banners com_content com_fields com_finder com_newsfeeds com_tags com_users |
| Labels |
Added:
?
|
||
shur
- comment
- 14 Dec 2016
I have tested this item
Code review. Good!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13183.
| Status | Pending | ⇒ | Ready to Commit |
jeckodevelopment
- comment
- 14 Dec 2016
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13183.
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-14 20:12:00 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
cpfeifer
-
I have tested this item✅ successfully on 257827f
Code review. Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13183.