Feeling Lucky
?
[#13173] - Coding style - PHP code tag and control structures III
- Fixed in Code Base
- 14 Dec 2016
- Medium
- Build: staging
- # 13173
- Diff
- marcochirienti:staging-coding-style-6
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Removed unnecessary spaces after PHP code opening tag.
Removed unnecessary spaces before PHP code closing tag.
Added a white-space before PHP code closing tag where missing.
Fixed style for control structures alternative syntax.
Added a semicolon at the end of statement where missing.
Testing Instructions
Code review.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_banners com_categories com_checkin com_config com_contact com_content com_contenthistory com_fields com_finder com_installer com_joomlaupdate |
C-Lodder
- comment
- 13 Dec 2016
I have tested this item
based on code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13173.
| Status | Pending | ⇒ | Ready to Commit |
jeckodevelopment
- comment
- 13 Dec 2016
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13173.
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-14 20:09:41 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
cpfeifer
-
I have tested this item✅ successfully on 401a205
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13173.