[#13158] - TranslateFormat in all other forms
- Fixed in Code Base
- 15 Jan 2017
- Medium
- Build: staging
- # 13158
- Diff
- Bakual:TranslateFormat
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
This PR extends the use of the new feature for translated date (and time) formats in the calendar formfield to all other core extensions.
#12102 originally introduced that feature but only did it for com_content.
Summary of Changes
Replace the hardcoded format in the form declaration with translateFormat="true" and showTime="true" where appropriate.
Testing Instructions
- Add the new language strings to your second language you have installed. Eg for de-DE add this to both de-DE.ini files (frontend and backend):
DATE_FORMAT_CALENDAR_DATE="%d.%m.%Y"
DATE_FORMAT_CALENDAR_DATETIME="%d.%m.%Y %H:%M:%S"
DATE_FORMAT_FILTER_DATETIME="d.m.Y H:i:s"
DATE_FORMAT_FILTER_DATE="d.m.Y"
- Make sure all instances of a calendar formfield (usually the created/modified/publish_up/publish_down) are using the translated format and don't create an error when saving.
Documentation Changes Required
None that I'm aware of.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_banners com_contact com_content com_finder com_modules com_newsfeeds com_tags com_users Front End com_config Modules |
| Labels |
Added:
?
|
||
Looks OK on review.
works as described.
Maybe for another PR, but notice several other places the date format is not translated
Version:
Category
field
user list
and probably more.
For this PR I did a search for the calendar type formfield.
- The version date is not a formfield at all. That should be done using one of the regular translated date formats. Currently it is hardcoded. See https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_contenthistory/views/history/tmpl/modal.php#L149
- The category edit for some reason uses a text field instead of the calendar one we use elsewhere. See https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_categories/models/forms/category.xml#L185-L192
Same thing for the field edit. It would have to be changed to calendar to support this feature. Imho it should be done in another PR as it also has other implications (like applying the timezone difference).
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13158.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13158.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13158.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-15 01:50:10 |
| Closed_By | ⇒ | wilsonge |
Affected extensions are:
Backend
Frontend
Modules