Feeling Lucky
?
[#13149] - Coding style - PHP code tag and control structures II
- Fixed in Code Base
- 11 Dec 2016
- Medium
- Build: staging
- # 13149
- Diff
- marcochirienti:staging-coding-style-5
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary of Changes
Removed unnecessary spaces after PHP code opening tag.
Removed unnecessary spaces before PHP code closing tag.
Added a white-space before PHP code closing tag where missing.
Fixed style for control structures alternative syntax.
Added a semicolon at the end of statement where missing.
Testing Instructions
Code review.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_config com_contact com_content com_finder |
jeckodevelopment
- comment
- 10 Dec 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13149.
andrepereiradasilva
- comment
- 10 Dec 2016
I have tested this item
on code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13149.
| Status | Pending | ⇒ | Ready to Commit |
jeckodevelopment
- comment
- 10 Dec 2016
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13149.
| Milestone |
Added: |
||
rdeutz
- comment
- 11 Dec 2016
@marcochirienti could you have a look at the conflicts, thanks
| Labels |
Added:
?
|
||
| Category | Front End com_config com_contact com_content com_finder | ⇒ | Front End com_contact com_content com_newsfeeds com_users |
marcochirienti
- comment
- 11 Dec 2016
It should be OK now.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-11 15:21:09 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
zero-24
- comment
- 11 Dec 2016
Merged Thanks!
cpfeifer
-
Thank you.