Feeling Lucky
?
[#13147] - Add a static flag to check if the event is registered (Fix #13124)
- Fixed in Code Base
- 9 Dec 2016
- Medium
- Build: staging
- # 13147
- Diff
- mbabker:event-has-listener
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #13124
Summary of Changes
Add a static flag inside JInstallerAdapterPackage to check if we've already registered the internal event callback to prevent adding it multiple times. JEventDispatcher is apparently supposed to do this but the checks seem woefully inefficient causing the error shown in that issue.
Testing Instructions
Installing multiple packages together works.
Documentation Changes Required
N/A
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
dgt41
- comment
- 9 Dec 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13147.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 9 Dec 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13147.
| Milestone |
Added: |
||
Bakual
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-09 14:40:45 |
| Closed_By | ⇒ | Bakual | |
| Labels |
Added:
?
?
|
||
cpfeifer
-
I have tested this item✅ successfully on 0efd62e
I can confirm I can install multiple languages at once again
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13147.